daddyz / phonelib

Ruby gem for phone validation and formatting using google libphonenumber library data
MIT License
1.04k stars 130 forks source link

Rename Velcom carrier to A1 #243

Closed alex-areshnikov closed 2 years ago

alex-areshnikov commented 2 years ago

This pull request resolves issue #242

alex-areshnikov commented 2 years ago

Looks like Travis fails because of this https://github.com/travis-ci/travis.rb/issues/809

daddyz commented 2 years ago

I can't accept this PR, extended_data.dat file is being generated every time I am updating the data from libphonenumber. What can be done is some config var that will override existing data, check additional_regex in readme