search

dadhi / FastExpressionCompiler

Fast Compiler for C# Expression Trees and the lightweight LightExpression alternative. Diagnostic and code generation tools for the expressions.
MIT License
1.14k stars 81 forks source link

Consider signed package version #57

Closed dadhi closed 5 years ago

dadhi commented 6 years ago

Yep, consider.

jogibear9988 commented 6 years ago

https://github.com/MahApps/MahApps.Metro/issues/3029

jogibear9988 commented 6 years ago

https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/strong-name-signing.md

dadhi commented 5 years ago

So should I consider to sign v2.0 or leave it for now?

jogibear9988 commented 5 years ago

I would leave it

Japollack commented 5 years ago

Getting back to the source of not signing it, it is now (again) recommended to sign the assambles. Pedro Lamas: Start Strong-Naming your Assemblies! image

As a final note to open-source library developers, I strongly recommend that the strong-name key file gets check-in to the project repository so that anyone can easily clone the project and compile a version of the library that works with anyone else’s binaries!

dadhi commented 5 years ago

Hi, Thanks for the link. I am aware of the trend :)

Likely to sign v2.