dadi / api-wrapper-core

Core high-level methods for interacting with DADI API
2 stars 2 forks source link

Remove reserved properties from update and create #4

Closed eduardoboucas closed 7 years ago

eduardoboucas commented 7 years ago

When passing a document to update() or create(), the operation will fail if the object contains reserved properties (like _id or createdAt). To make these operation safe, this PR strips any reserved properties from the document being created/updated.

eduardoboucas commented 7 years ago

@jimlambie are you happy with this?

jimlambie commented 7 years ago

I'm happy if you're happy! Tests pass? Merge! It's auto-releasing. On Tue, 21 Mar 2017 at 02:21, Eduardo Bouças notifications@github.com wrote:

@jimlambie https://github.com/jimlambie are you happy with this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dadi/api-wrapper-core/pull/4#issuecomment-287756793, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHGJ5KHvq7h7_4YY4mH-MM0pJRoeagLks5rnn1kgaJpZM4MhlFQ .