search

dadish / ProcessGraphQL

GraphQL for ProcessWire
MIT License
106 stars 14 forks source link

Composer Install - Now required #48

Closed brettwilcox closed 2 years ago

brettwilcox commented 3 years ago

Release: 1.4.0-rc1 Problem: When upgrading the module, ProcessWire will throw an error. Solution: Use composer install in the module directory.

https://github.com/dadish/ProcessGraphQL/blob/530a72e349d7a262d26af9452f5681fa36ee5d33/ProcessGraphQLConfig.php#L8

Fix: Should the /vendor/ folder be included with the module, or is it expected for the user to configure a build process? Proposed: Modify .gitignore and remove the vendor reference and include required files.

dadish commented 3 years ago

The repository is kept clean for better developer experience. It also help us with the CI builds and other tooling.

For the latest module that you want to use with ProcessWire, you can download a packaged module files with only files needed for the module and all the redundant files stripped away. Unfortunately it's not obvious and can be confused with the repository zip file instead of the module zip file.

Screen Shot 2021-10-14 at 10 06 41 AM

I will update the Readme and try to make it much clearer. 👍

dadish commented 2 years ago

:tada: This issue has been resolved in version 1.4.0-rc.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

dadish commented 2 years ago

:tada: This issue has been resolved in version 1.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: