search

dadler / thumbnail-zoom

Thumbnail Zoom Plus is a Firefox plug-in which shows a full-size image pop-up when you hover over a thumbnail or image link. When you hover your mouse over a thumbnail or an image or video link, the add-on displays the full-size image or video still-frame in a floating window. Supported sites include Amazon, Bing, Facebook, Flickr, Google, IMDb, LinkedIn, Netflix, Pinterest, Reddit, Tumblr, Twitter, Yandex.ru, YouTube, Wikipedia, WordPress, Yahoo Images, and many more.
30 stars 7 forks source link

TZP stops working on Nightly ff21.0 (ff20 too?) #108

Closed Fanolian closed 11 years ago

Fanolian commented 11 years ago

Thanks for the indispensable extension. It greatly improves my browsing experience on image-heavy sites. However, TZP does not work on Nightly now.

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:21.0) Gecko/20130109 Firefox/21.0 Tested on a new profile with only TZP installed.

Steps to reproduce:

  1. Go to a site TZP supports, e.g. http://www.reddit.com/r/pics/ or https://www.google.com/search?num=10&hl=en&site=imghp&tbm=isch&source=hp&biw=1276&bih=983&q=thumbnail&oq=thumbnail
  2. Hover on a thumbnail. TZP should show the original image once.
  3. Hover on another thumbnail. TZP now stops working on subsequent hovering.

If I move the mouse vertically in the content window it generates a bunch of error messages in error console: Timestamp: {censored} Error: TypeError: this._currentWindow is null Source File: chrome://thumbnailzoomplus/content/overlay.js Line: 534

If I switch to another tab and go back to the original tab, TZP works once again but fails on subsequent hoverings.

By using Mozregression, the regression range should be: Last good nightly: 2013-01-04 First bad nightly: 2013-01-05 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=801ba75ac563&tochange=d8ca3e1c469e

A summary of the changes on 20130105 build can be found at http://forums.mozillazine.org/viewtopic.php?f=23&t=2637011 Since the changes has been merged into Aurora so I guess it will stick to Firefox20 release probably.

dadler commented 11 years ago

I have reproduced this problem and will investigate (and will hope the problem goes away in the next nightly). I don't see anything in the change list which looks obviously related.

In the meantime the only workaround I know is to run an older version of Firefox. Thanks for the detailed problem report.

David

Batchman85 commented 11 years ago

Confirming bug in Aurora (build from 2013-1-11)

waiting for update

Tnx

dadler commented 11 years ago

Thanks, I'll investigate. On Jan 10, 2013 3:21 AM, "Fanolian" notifications@github.com wrote:

Thanks for the indispensable extension. It greatly improves my browsing experience on image-heavy sites. However, TZP does not work on Nightly now.

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:21.0) Gecko/20130109 Firefox/21.0 Tested on a new profile with only TZP installed.

Steps to reproduce:

  1. Go to a site TZP supports, e.g. http://www.reddit.com/r/pics/ or https://www.google.com/search?num=10&hl=en&site=imghp&tbm=isch&source=hp&biw=1276&bih=983&q=thumbnail&oq=thumbnail
  2. Hover on a thumbnail. TZP should show the original image once.
  3. Hover on another thumbnail. TZP now stops working on subsequent hovering.

If I move the mouse vertically it generates a bunch of error messages in error console: Timestamp: {censored} Error: TypeError: this._currentWindow is null Source File: chrome://thumbnailzoomplus/content/overlay.js Line: 534

If I switch to another tab and go back to the original tab, TZP works once again but fails on subsequent hoverings.

By using Mozregression, the regression range should be: Last good nightly: 2013-01-04 First bad nightly: 2013-01-05 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=801ba75ac563&tochange=d8ca3e1c469e

A summary of the changes on 20130105 build can be found at http://forums.mozillazine.org/viewtopic.php?f=23&t=2637011 Since the changes has been merged into Aurora so I guess it will stick to Firefox20 release probably.

— Reply to this email directly or view it on GitHubhttps://github.com/dadler/thumbnail-zoom/issues/108.

dadler commented 11 years ago

This should be fixed now in Thumbnail Zoom Plus 2.3.2 and 2.4rc3. https://addons.mozilla.org/en-US/firefox/addon/thumbnail-zoom-plus/versions

It works for the most part but some less serious problems may remain; I'm continuing to investigate. Firefox seems to be calling image.onload and image.onerror at the wrong times.

Fanolian commented 11 years ago

Thanks for the update. TZP 2.4rc3 can show thumbnails properly until it actually encounters an error.

STR: Given 3 links: a: http://wiki.guildwars2.com/images/5/56/Nightmare_Torch.jpg b: http://wiki.guildwars2.com/images/e/ee/Modniir_Wartorch.jpg c: http://wiki.guildwars2.com/wiki/File:Modniir_Wartorch.jpg

  1. Hover on link a, a thumbnail is shown. Hover on link b or other working links in the same tab, a thumbnail is also shown. The previous issued should have fixed.
  2. Hover on link c, TZP cannot show a thumbnail, which is expected.
  3. Hover back on link a or b, TZP cannot show thumbnails anymore until I switch tab.

This time, TZP throws an error message in error console only if I move the mouse horizontally instead of vertically: Timestamp: Error: TypeError: this._currentWindow is null Source File: chrome://thumbnailzoomplus/content/overlay.js Line: 558

dadler commented 11 years ago

Thanks; I'm able to reproduce with those steps.

dadler commented 11 years ago

Verified that the 3-step repro procedure does not cause a problem in Firefox 18 with TZP 2.4rc3.

dadler commented 11 years ago

The problem in ff20 is avoided if I modify the code to always load via an xml image instead of an http image, but (at least in earlier versions of Firefox) that prevents a partially-loaded image from displaying as fast so it's not a good workaround.