search

dadler / thumbnail-zoom

Thumbnail Zoom Plus is a Firefox plug-in which shows a full-size image pop-up when you hover over a thumbnail or image link. When you hover your mouse over a thumbnail or an image or video link, the add-on displays the full-size image or video still-frame in a floating window. Supported sites include Amazon, Bing, Facebook, Flickr, Google, IMDb, LinkedIn, Netflix, Pinterest, Reddit, Tumblr, Twitter, Yandex.ru, YouTube, Wikipedia, WordPress, Yahoo Images, and many more.
30 stars 7 forks source link

doesn't load in Nightly 35 due to javascript 'let' incompatibility #164

Closed dadler closed 9 years ago

dadler commented 9 years ago

Around Sep 16, 2014, Thumbnail Zoom Plus is Firefox Nightly 35 stopped working. The add-on doesn't load properly; its toolbar menu has only Preferences and Help, and no pop-ups appear.

After starting up with an empty tab, the Browser Console shows:

TypeError: redeclaration of variable match pages.js:1696 TypeError: ThumbnailZoomPlusChrome.Overlay is undefined

The cause is an incompatible change to javascript itself in ff 35, described here: https://groups.google.com/forum/#!topic/mozilla.dev.platform/tezdW299Zds

In this version, it's illegal to use "let" to declare the same variable more than once in the same block. The fix is to change subsequent "let" statements to simple assignments. There are likely several instances of thism besides the first one where the error is reported.

Problem initially reported by T. R. Harris and "Jeff" by email.

dadler commented 9 years ago

Fix released in 3.1beta1. https://addons.mozilla.org/en-US/firefox/addon/thumbnail-zoom-plus/versions/