search

dadler / thumbnail-zoom

Thumbnail Zoom Plus is a Firefox plug-in which shows a full-size image pop-up when you hover over a thumbnail or image link. When you hover your mouse over a thumbnail or an image or video link, the add-on displays the full-size image or video still-frame in a floating window. Supported sites include Amazon, Bing, Facebook, Flickr, Google, IMDb, LinkedIn, Netflix, Pinterest, Reddit, Tumblr, Twitter, Yandex.ru, YouTube, Wikipedia, WordPress, Yahoo Images, and many more.
30 stars 7 forks source link

Hang until script stopped on Pinterest , related to caption text #166

Closed decembre closed 9 years ago

decembre commented 10 years ago

when i open a Pinterest page, by example: Apology 5 by David Fullarton, via Flickr

The page hang and I got an error message about : Script : chrome://thumbnailzoomplus/content/overlay.js:1089

i need to disable ThumbnailZoom to resolve that....

I am on firefox 32.0.2 win 7

dadler commented 10 years ago

I'm not able to reproduce this in Thumbnail Zoom Plus 3.0. What version of TZP are you running? Do you have the specific error message (besides just the filename and line number)?

Do you mean the problem happens when you open the page itself, and it causes the page not to display? Or the page opens, but hangs when you hover a thumbnail on it?

Thanks, David

On 9/21/14, 1:54 AM, decembre wrote:

when i open a Pinterest page, by example: Apology 5 by David Fullarton, via Flickr http://www.pinterest.com/pin/62135669833819279/

The page hang and I got an error message about : Script : chrome://thumbnailzoomplus/content/overlay.js:1089

i need to disable ThumbnailZoom to resolve that....

I am on firefox 32.0.2 win 7

— Reply to this email directly or view it on GitHub https://github.com/dadler/thumbnail-zoom/issues/166.

decembre commented 10 years ago

It's the 3.0 version. It happens on page load. The content is displayed but hang quickly.

Some TESTS:

Maybe an extension conflict ?

Here a part of the "too BIG FAT log": [shortened] === : 22:27:27.227: isURLEnabled http://www.pinterest.com/pin/277112183297081074/ ... === : 22:27:27.227: Page URL allowed by disabledSitesRE: http://www.pinterest.com/pin/277112183297081074/ === : 22:27:27.229: updateSiteInPrefsDialog for host www.pinterest.com === : 22:27:27.229: isURLEnabled http://www.pinterest.com/pin/277112183297081074/ ... === 22:27:27.665 W DOM_Core: [JavaScript Warning: "L'utilisation de « getPreventDefault() » est obsolète. Utiliser « defaultPrevented » à la place." {file: "https://s-passets-ec.pinimg.com/webapp/js/app/desktop/bundle-1.4356ac5d.js" line: 3}] === 22:27:27.775 X system_javascript: [JavaScript Error: "Permission refusée à http://www.pinterest.com de créer une classe enveloppante pour l'objet de la classe UnnamedClass" {file: "chrome://google-toolbar-lib/content/toolbar.js" line: 1229}] === : 22:27:29.249: ThumbnailZoomPlus: <<< SEEKING image for name="div" class="trackActiveItem padItems Module ajax GridItems variableHeightLayout" url= [object XrayWrapper [object HTMLDivElement]] pageUrl=http://www.pinterest.com/pin/277112183297081074/ === : 22:27:29.25: ThumbnailZoomPlus: !!! PAGE 'pinterest' (19) imageRegExp or imageDisallowRegExp rejected imageSource null === : 22:27:29.251: ThumbnailZoomPlus: !!! PAGE 'wikipedia' (26) imageRegExp or imageDisallowRegExp rejected imageSource null === : 22:27:29.252: ThumbnailZoomPlus: !!! PAGE 'others' (27) imageRegExp or imageDisallowRegExp rejected imageSource null === : 22:27:29.253: ThumbnailZoomPlus: !!! PAGE 'thumbnail' (28) imageRegExp or imageDisallowRegExp rejected imageSource null === : 22:27:29.254: ThumbnailZoomPlus: !!! PAGE 'othersindirect' (29) imageRegExp or imageDisallowRegExp rejected imageSource null === : 22:27:29.254: ThumbnailZoomPlus: !!! PAGE 'thumbnail' (30) imageRegExp or imageDisallowRegExp rejected imageSource null === : 22:27:29.254: ThumbnailZoomPlus: >>> all pages rejected === : 22:27:29.609: ThumbnailZoomPlus: <<< SEEKING image for name="span" class="hoverMask" url= [object XrayWrapper [object HTMLSpanElement]] pageUrl=http://www.pinterest.com/pin/277112183297081074/ === : 22:27:29.61: ThumbnailZoomPlus: >>> PAGE 'pinterest' (19): imageSourceNode: url: [object XrayWrapper [object HTMLImageElement]] http://media-cache-ak0.pinimg.com/70x/e6/0a/fe/e60afe55d373bf450b273bc9b231d50b.jpg === : 22:27:29.611: ThumbnailZoomPlus: !!! PAGE 'pinterest' (19) matches imageSource http://media-cache-ak0.pinimg.com/70x/e6/0a/fe/e60afe55d373bf450b273bc9b231d50b.jpg === : 22:27:29.611: _getZoomImageCompletionImmediate: getZoomImageResult=http://media-cache-ak0.pinimg.com/550x/e6/0a/fe/e60afe55d373bf450b273bc9b231d50b.jpg; type=string === : 22:27:29.611: ThumbnailZoomPlus: >>> page pinterest launching http://media-cache-ak0.pinimg.com/550x/e6/0a/fe/e60afe55d373bf450b273bc9b231d50b.jpg === : 22:27:30.307: _checkIfImageLoaded: naturalWidth=0; width=0; iw=0 === : 22:27:30.729: _checkIfImageLoaded: naturalWidth=510; width=510; iw=510 === 22:27:31.209 X system_javascript: [JavaScript Error: "Permission refusée à https://www.flickr.com de créer une classe enveloppante pour l'objet de la classe UnnamedClass" {file: "chrome://google-toolbar-lib/content/toolbar.js" line: 1229}] === : 22:27:31.212: ThumbnailZoomPlus: image tag type: img === : 22:27:31.212: _imageOnLoad: width=510; height=1342.width=510; .videoWidth=undefined === : 22:27:31.252: ThumbnailZoomPlus: showed popup === : 22:27:31.706: ThumbnailZoomPlus: <<< SEEKING image for name="span" class="hoverMask" url= [object XrayWrapper [object HTMLSpanElement]] pageUrl=http://www.pinterest.com/pin/277112183297081074/ === : 22:27:31.707: ThumbnailZoomPlus: >>> PAGE 'pinterest' (19): imageSourceNode: url: [object XrayWrapper [object HTMLImageElement]] http://media-cache-ak0.pinimg.com/70x/67/9a/2d/679a2d812eb064e76be1072f497f9c06.jpg === : 22:27:31.707: ThumbnailZoomPlus: !!! PAGE 'pinterest' (19) matches imageSource http://media-cache-ak0.pinimg.com/70x/67/9a/2d/679a2d812eb064e76be1072f497f9c06.jpg === : 22:27:31.707: _getZoomImageCompletionImmediate: getZoomImageResult=http://media-cache-ak0.pinimg.com/550x/67/9a/2d/679a2d812eb064e76be1072f497f9c06.jpg; type=string === : 22:27:31.707: ThumbnailZoomPlus: >>> page pinterest launching http://media-cache-ak0.pinimg.com/550x/67/9a/2d/679a2d812eb064e76be1072f497f9c06.jpg === 22:27:55.109 E content_javascript: [JavaScript Error: "TypeError: d is undefined" {file: "https://s-passets-ec.pinimg.com/webapp/js/app/desktop/bundle-2.6c51bd12.js" line: 25}] === : 22:27:56.213: updateSiteInPrefsDialog for host www.pinterest.com === : 22:27:56.213: isURLEnabled http://www.pinterest.com/pin/277112183297081074/ ... === : 22:27:56.432: isURLEnabled about:blank ... === : 22:27:56.432: Page URL allowed by disabledSitesRE: about:blank === : 22:27:56.432: updateSiteInPrefsDialog for host www.pinterest.com === : 22:27:56.432: isURLEnabled http://www.pinterest.com/pin/277112183297081074/ ... === : 22:27:56.948: ThumbnailZoomPlus: <<< SEEKING image for name="span" class="hoverMask" url= [object XrayWrapper [object HTMLSpanElement]] pageUrl=http://www.pinterest.com/pin/277112183297081074/ === : 22:27:56.949: ThumbnailZoomPlus: >>> PAGE 'pinterest' (19): imageSourceNode: url: [object XrayWrapper [object HTMLImageElement]] http://media-cache-ak0.pinimg.com/70x/1f/31/32/1f313246ec1e6492f5bd05f7ab72636d.jpg === : 22:27:56.949: ThumbnailZoomPlus: !!! PAGE 'pinterest' (19) matches imageSource http://media-cache-ak0.pinimg.com/70x/1f/31/32/1f313246ec1e6492f5bd05f7ab72636d.jpg === : 22:27:56.949: _getZoomImageCompletionImmediate: getZoomImageResult=http://media-cache-ak0.pinimg.com/550x/1f/31/32/1f313246ec1e6492f5bd05f7ab72636d.jpg; type=string === : 22:27:56.95: ThumbnailZoomPlus: >>> page pinterest launching http://media-cache-ak0.pinimg.com/550x/1f/31/32/1f313246ec1e6492f5bd05f7ab72636d.jpg === : 22:28:17.901: updateSiteInPrefsDialog for host www.pinterest.com === : 22:28:17.901: isURLEnabled http://www.pinterest.com/pin/277112183297081074/ ... === : 22:28:19.083: updateSiteInPrefsDialog for host www.pinterest.com === : 22:28:19.083: isURLEnabled http://www.pinterest.com/pin/277112183297081074/ ... === : 22:28:19.23: isURLEnabled data:text/html;charset=utf8,<!DOCTYPE%20html><html%20dir='ltr'>%20%20%20%20%20%20%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/skin/devtools/common.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/codemirror.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/dialog.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/mozilla.css'>%20%20%20%20<body%20class='theme-body%20devtools-monospace'> ... === : 22:28:19.23: Page URL allowed by disabledSitesRE: data:text/html;charset=utf8,<!DOCTYPE%20html><html%20dir='ltr'>%20%20%20%20%20%20%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/skin/devtools/common.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/codemirror.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/dialog.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/mozilla.css'>%20%20%20%20<body%20class='theme-body%20devtools-monospace'> === : 22:28:19.232: updateSiteInPrefsDialog for host www.pinterest.com === : 22:28:19.232: isURLEnabled http://www.pinterest.com/pin/277112183297081074/ ... === : 22:28:26.272: updateSiteInPrefsDialog for host www.pinterest.com === : 22:28:26.272: isURLEnabled http://www.pinterest.com/pin/277112183297081074/ ... === : 22:28:44.528: updateSiteInPrefsDialog for host www.pinterest.com === : 22:28:44.529: isURLEnabled http://www.pinterest.com/pin/277112183297081074/ ... === : 22:28:44.529: thumbnailZoomPlus: onsyncfrompreference === : 22:28:44.53: ThumbnailZoomPlus: pref value is === : 22:28:44.545: updateSiteInPrefsDialog for host www.pinterest.com === : 22:28:44.546: isURLEnabled http://www.pinterest.com/pin/277112183297081074/ ... === : 22:28:44.546: thumbnailZoomPlus: onsyncfrompreference === : 22:28:44.546: ThumbnailZoomPlus: pref value is === : 22:28:44.582: ThumbnailZoomPlusOptions.init() === : 22:28:44.582: updateSiteInPrefsDialog for host www.pinterest.com === : 22:28:44.582: isURLEnabled http://www.pinterest.com/pin/277112183297081074/ ...

decembre commented 10 years ago

Here the console log: 23:43:16.448: updateSiteInPrefsDialog for host www.pinterest.com

23:43:16.448: isURLEnabled http://www.pinterest.com/pin/62135669833819279/ ...

23:43:17.526: ThumbnailZoomPlus: <<< SEEKING image for name="span" class="cm-keyword" url= [object HTMLSpanElement] pageUrl=data:text/html;charset=utf8,<!DOCTYPE%20html><html%20dir='ltr'>%20%20%20%20%20%20%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/skin/devtools/common.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/codemirror.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/dialog.css'>%20%20%20%20<link%20rel='stylesheet'%20href='chrome://browser/content/devtools/codemirror/mozilla.css'>%20%20%20%20<body%20class='theme-body%20devtools-monospace'>

23:43:17.527: ThumbnailZoomPlus: !!! PAGE 'wikipedia' (26) imageRegExp or imageDisallowRegExp rejected imageSource null

23:43:17.528: ThumbnailZoomPlus: !!! PAGE 'others' (27) imageRegExp or imageDisallowRegExp rejected imageSource null

23:43:17.529: ThumbnailZoomPlus: !!! PAGE 'thumbnail' (28) imageRegExp or imageDisallowRegExp rejected imageSource null

23:43:17.529: ThumbnailZoomPlus: !!! PAGE 'othersindirect' (29) imageRegExp or imageDisallowRegExp rejected imageSource null

23:43:17.53: ThumbnailZoomPlus: !!! PAGE 'thumbnail' (30) imageRegExp or imageDisallowRegExp rejected imageSource null

23:43:17.53: ThumbnailZoomPlus: >>> all pages rejected

dadler commented 10 years ago

In that detailed log I don't see the error message (no "overlay.js").

There is a conflict with Flashblock in version 3.0, which is fixed in 3.1beta1 (#162). Perhaps you had flashblock conflict in the first profile, but the second profile didn't have it, which is why it worked? Does 3.1beta1 work in the first profile?

decembre commented 10 years ago

Test on the first profile the TZP v3.1: Seem hang too...

I use NoScripts and AdblockPopup :

Test without these extensions on the first profile: Always the same problem

dadler commented 10 years ago

To make sure I understand:

After you disable those two extensions from first profile, pinterest still hangs. But it doesn't hang on second profile.

What differences are there between the two profiles? Are there any other add-ons enabled in the first profile? Are there any TZP preferences differences between the two?

If we can't find an explanation, we might assume that the first profile is somehow corrupt.

decembre commented 10 years ago

I need to test more.... But the corruption seems the reason. Sorry your time lost on this "bug" ;-)

dadler commented 10 years ago

No problem. I'm closing the issue but let me know if you discover a way for me to reproduce it.

dadler commented 9 years ago

Another user ("Peter", by email) has reported the problem and I'm now able to reproduce it, on this page: http://www.pinterest.com/pin/354095589426144462/?od=%2F4BFx0rfI4uoUIt0vYDn5o6S4JYyZ%2B4rMIdiUXWGTCkuNwZ6oouSRM070RJOrXnG9QzPZgD8mIYJ%0AmmikHrB%2B5DWrw2uWBBK%2Fhj1u%2Bo8rszuAhFWoylg1sNCNAF2jowThhihNhH4vRHM5IDk10L6cvLye%0AQZ1SHfdIrC9%2BIgPTkiKYMd%2FiVajGlW87%2F8q1k9%2B7%0A&user_id=cGxlZnNlYWZmQGdtYWlsLmNvbQ%3D%3D%0A&conversation=4718600635715426270&invite_code=653b4f88d744da4daecbcf93878f06bd&utm_campaign=msgpin&e_t=8eb18b040ac54e6e8c89471702ad11a0&utm_content=354095589426144462&utm_source=31&e_t_s=cta&utm_medium=2000

Error dialog:

A script on this page may be busy, or it may have stopped responding. You can stop the script now, open the script in the debugger, or let the script continue. Script: chrome://thumbnailzoomplus/content/overlay.js:1133

The problem happens on this page when I hover over one of the small thumbs to the right of the big video player. When run with verbose logging on, I see that the initial text for caption is many lines long; apparently Firefox's string.replace is very slow in that situation.

Reproduced in Firefox 33.1.1 on OS X Mavericks with TZP settings: Caption on, Pop-up takes keyboard focus on, all checkboxes on except Others, Others (Indirect), and Thumbnails.

dadler commented 9 years ago

The fix is released in 3.2beta13.

decembre commented 9 years ago

thanks, that's solve my problem!