Right mouse button option prevents spell check corrections - Githubissues

dadler / thumbnail-zoom

Thumbnail Zoom Plus is a Firefox plug-in which shows a full-size image pop-up when you hover over a thumbnail or image link. When you hover your mouse over a thumbnail or an image or video link, the add-on displays the full-size image or video still-frame in a floating window. Supported sites include Amazon, Bing, Facebook, Flickr, Google, IMDb, LinkedIn, Netflix, Pinterest, Reddit, Tumblr, Twitter, Yandex.ru, YouTube, Wikipedia, WordPress, Yahoo Images, and many more.

30 stars 7 forks source link

Right mouse button option prevents spell check corrections #172

Closed dadler closed 9 years ago

dadler commented 9 years ago

In TZP 3.2beta1, the Firefox spell checker underlines misspelled works, but no longer shows suggestions in the right-click menu. This is reproducible e.g. in the Facebook status input field.

The problem happens even when a different key such as Shift is chosen in Preferences, and even if TZP's "Enable" checkbox is off.

We'll need to either fix this for 3.2beta2 or disable the right mouse button feature.

Reported on Wordpress by Marucins.

dadler commented 9 years ago

In 3.2beta2 I've improved it so the problem happens only if Right Mouse Button is the value of Key to [display | not display].

dadler commented 9 years ago

I've made a few attempts but haven't been able to solve this. I've tried:

dispatching from different event targets (originalTarget, target, explicitOriginalTarget).
creating the mouse via new MouseEvent(), so that it can contain more target-releated fields.

dadler commented 9 years ago

removed 'p1' label since problem now happens only when set to Right Mouse Button.

dadler commented 9 years ago

Wrong commit tagged; issue actually fixed here: commit 337e56d2a00b6f13136ba9ca300ff23112b9bd02 Author: David Adler browser.add.ons@davidadler.name Date: Sun Oct 12 17:50:38 2014 -0700

Fixed #177: Right mouse button option in 3.2beta1 prevents spell check corrections.

The fix is to allow the context menu to pop up immediately on text areas, which allows the
spell checker to show suggestions.  This means if you try to right-drag from a text area onto a
link or image, you'll see a context menu, but that's probably not a common usage.