Video keeps flashing - Githubissues

dadler / thumbnail-zoom

Thumbnail Zoom Plus is a Firefox plug-in which shows a full-size image pop-up when you hover over a thumbnail or image link. When you hover your mouse over a thumbnail or an image or video link, the add-on displays the full-size image or video still-frame in a floating window. Supported sites include Amazon, Bing, Facebook, Flickr, Google, IMDb, LinkedIn, Netflix, Pinterest, Reddit, Tumblr, Twitter, Yandex.ru, YouTube, Wikipedia, WordPress, Yahoo Images, and many more.

30 stars 7 forks source link

Video keeps flashing #180

Open garyking opened 10 years ago

garyking commented 10 years ago

The video here keeps flashing when hovered. I can see the content behind the video on the page when I'm hovering over it.

dadler commented 10 years ago

So you mean you hover the link on github.com, and see the movie in the TZP pop-up, but the pop-up flashes or is partially transparent? I'm not seeing that problem on my mac or on Windows XP.

I do see that the frame rate isn't as good in TZP (the motion stutters a little) but that seems to be an inherent Firefox limitation.

garyking commented 10 years ago

Yeah the pop-up is flashing, and every time it flashes, it is transparent. I'm on a Mac OS X and Firefox, latest stable versions for both. The framerate doesn't really seem to be a problem for the hover.

dadler commented 10 years ago

Trying to figure out how to reproduce it...

What versions of Firefox, OSX, and Thumbnail Zoom Plus?

Does it matter whether the Firefox window is maximized or full-screen?

What zoom percent is the video at?

Have you tested with all other add-ons disabled?

Is it only a problem with that particular webm video, or all webm videos?

garyking commented 10 years ago

Firefox 33.0.2, OS X 10.10, TZP 3.1
Problem happens when Firefox is "maximized" or smaller. But it doesn't happen when Firefox is full screened, when clicking the green button on Yosemite.
Video is at 167%
I tested it on a new profile with only TZP installed. Problem still exists.
The problem occurs occasionally with other WebM videos too, but I notice it isn't consistent with those. The problem is more consistent with this particular one.

garyking commented 9 years ago

The flashing is still occurring. It seems to only affect Gfycat links, although I guess more accurately, it affects WebM videos. I even tried the latest beta and the problem still exists there.

Could TZP please grab the GIF version of WebM videos, at least from Gfycat, so that the flashing no longer occurs? Or, I guess the reason this is not an option is because it only happens for a subset of users?

dadler commented 9 years ago

Do far yours it'd the only report I've had of this problem and I can't reproduce it on my mac (but I'm still on Mavericks).

garyking commented 9 years ago

Is it possible to add an option to switch between WebM and GIF version of images? I think although sites like Imgur and Gfycat now support WebM, they also still support GIF versions of them too.

dadler commented 9 years ago

Gary, could you check if the problem still happens after you go to about:config and set layers.offmainthreadcomposition.enabled to 'false'? That setting being 'true' caused some problems on Windows, and I'm wondering if it's the problem on Yosemite OS X too.

garyking commented 9 years ago

I set it to false, problem still persists.

dadler commented 9 years ago

I've just upgraded to Yosemite 10.10, and can now reproduce it (in 10.10.1 too). A good repro video for me is: http://gfycat.com/AmbitiousLastingBooby

dadler commented 9 years ago

Turning off layers.offmainthreadcomposition.enabled doesn't help. Turning off Firefox Advanced Preference 'Use hardware acceleration where available' doesn't help. Turning on layers.acceleration.disabled doesn't help. Removing the html:video tag from xml doesn't help. Initially creating the html:video tag in overlay.xml instead of creating it dynamically doesn't help.

dadler commented 9 years ago

It works better in these versions; I still see an occasional flash but significantly less often (< 8 flasher per loop of the star wars example).

Nightly 37.0a1 2014-11-29
Nightly 36.01a 2014-11-22, -29
Firefox Developer Edition 35.0a2 (2014-11-28).
Nightly 35.0a1 2014-09-30
Nightly 35.0a1 2014-09-15
Nightly 35.0a1 2014-09-13 (?)
Nightly 35.0a1 2014-09-11
Nightly 35.0a1 2014-09-07 (?)
Nightly 34.0a1 2014-08-30
Nightly 34.0a1 2014-08-01

It DOES NOT WORK in:

Firefox 33.1.1
Nightly 34.0a1 2014-07-31
Nightly 34.0a1 2014-07-29
Nightly 34.0a1 2014-07-27
Nightly 34.0a1 2014-07-21
Nightly 33.0a1 2014-07-14
Nightly 33.0a1 2014-07-03
Firefox 34.0b11 2014-11-21
Firefox Beta 34.0.5.

Conclusion: some change first appearing in 34.0a1 2014-08-01 improved (but didn't fix) the problem.

garyking commented 9 years ago

Damn that sucks. So now that you have confirmed the bug, in the meantime, is it possible to revert to GIF rather than WebM for us Yosemite + Firefox users?

dadler commented 9 years ago

I've found a partial workaround: I can make the current Firefox version play the movie as cleanly as Nightly (which is pretty clean but sometimes still a flash or two) by going to about:config and setting layers.enable-tiles to true.

dadler commented 9 years ago

I've found a partial workaround, which makes the current Firefox version (Firefox 33.3.1) play the movie as cleanly as Nightly (which is pretty clean but sometimes still a flash or two) by:

go to web address about:config
search for layers.enable-tiles
set it true.
restart firefox.

I also see that Firefox Nightly 37.0a1 2014-11-29 defaults that setting to 'true'. It starts showing the problem if I set layers.enable-tiles to false.

garyking commented 9 years ago

Thanks. What do these settings even do? Impressive that you can dig these settings up; there doesn't seem to be much documentation on them.

garyking commented 9 years ago

The problem seems to have improved since Firefox 35. It occurs still, but much less frequently.