dado3212 / spaces-renamer

💻 Ability to rename desktop spaces on macOS 10.10+
MIT License
1.05k stars 29 forks source link

Adding Display resets Desktop Names #15

Closed newgoliath closed 6 years ago

newgoliath commented 6 years ago

Plugging in a Display-Port Display cable resets Desktop Names to default names, i.e.desktop-1, etc. Configured names remain in spaces-renamer app.

Naming DP desktops with spaces-renamer app renames them on the laptop display, not the DP.

Removing DP cable returns laptop-display desktop names to what was set already in spaces-renamer.

To make it work with DP plugged in:

dado3212 commented 6 years ago

This is due to a lack of clarity in OSX in some places about which monitor is which. I have some possible ideas for a fix, I'll look into it later today and get back to you with a possible fix.

It doesn't actually reset the desktop names, it most likely just uses the named desktops for the spaces on the wrong monitor.

ryanerwin commented 6 years ago

@dado3212 @newgoliath I'm having the exact same problem and I can confirm that it's like @dado3212 says, the space names are correct - but they're on the wrong monitor.

I think multi monitor support may be one of the reasons that this isn't included in Mac OS X... It's not completely obvious what to do with spaces and space names as you disconnect and reconnect displays.

  1. 4K display connect to MBA... 5 named spaces on 4K display... 1 space on MBA good
  2. Disconnect 4K display, 5 names spaces are now on MBA (but where did 1 space go?)
  3. Reconnect 4K display, for OS X 5 spaces are back on 4K display (correct!) however Spaces Renamer shows those names on the MBA display...

Restart spacesRenamer then do killall Dock and things are back to normal.

dado3212 commented 6 years ago

It 100% could be included in actual OSX. It's just my approach is unbelievably hacky, and involves just finding the text layer where it's rendered, and changing that name, as opposed to changing it in whatever model it's actually referred to as.

I pushed an update (v1.4.0), can you let me know if that clears up your problem?

dado3212 commented 6 years ago

Marking as solved.

newgoliath commented 6 years ago

Works great! Thanks!