search

dadobug1111 / DadobugBedrockOres

Bedrock Ores For All
MIT License
0 stars 1 forks source link

Feature: Modular Routers compat #10

Closed Raidobw2 closed 2 years ago

Raidobw2 commented 2 years ago

I would like to see if compatibility for Modular Routers can be added. https://www.curseforge.com/minecraft/mc-mods/modular-routers

Currently the breaker module turns the blocks into air

Relayed from https://github.com/FTBTeam/FTB-Modpack-Issues/issues/1062 and will shortly report to Modular Routers as well, see below for the linked issue

Thanks for reading my suggestion :)

desht commented 2 years ago

The fundamental problem here is that Bedrock Ores relies on IForgeBlock#onDestroyedByPlayer() being called, which only occurs as a result of a ServerBoundPlayerActionPacket being received from a client. This does not happen when a block breaker type mod (like Modular Routers and its Breaker Module) breaks blocks purely server side, so your blocks don't get regenerated.

So this isn't just a Modular Routers compatibility question; it's about playing nice with any server-sided block breaker.

dadobug1111 commented 2 years ago

rewritten regen has fixed this, works wonderfully!

Raidobw2 commented 2 years ago

Awesome, much thanks! :D