Closed dadrus closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.74%. Comparing base (
14fc2de
) to head (71fc81f
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Related issue(s)
closes #1717
Checklist
Description
Implementation of unit tests for the helm chart.
During the course of this work, the following issues were identified and resolved:
heimdall/templates/deployment.yaml:28:22: executing "heimdall/templates/deployment.yaml" at <.Values.deployment.annotations>: nil pointer evaluating interface {}.deployment
. This was due to a copy-paste mistake in the template’s annotation access definition within thewith
clause. Instead of correctly using.
to reference the current context,.Values.deployment.annotations
was incorrectly used within the nested template.rules
property. However, the configuration for the admission controller (validating webhook) in the helm chart was not updated accordingly, and the helm chart still expected its configuration to be under therules
property.namespaceSelector
, causing them to be ignored by the Kubernetes server API.Changelist