search

daducci / COMMIT

Linear framework to combine tractography and tissue micro-structure estimation with diffusion MRI
Other
43 stars 33 forks source link

Bug with proximal operators #66

Closed daducci closed 4 years ago

daducci commented 4 years ago

In some cases, when using multi-compartment models and advanced regularization schemes, some proximal operators might not behave as expected. This PR should fix the issue.

daducci commented 4 years ago

Does this fix the problem? Probably it's not the best solution but it should do the trick for now

MarioOcampo commented 4 years ago

Yes, this solves one problem, I don't know which is the best solution either

MarioOcampo commented 4 years ago

The last commit (d2ed868) fixed the definition of the offsets for the compartments.

MarioOcampo commented 4 years ago

Tested on Ubuntu {16, 18} and python {2,3} NNLS with VolumeFractions and StickZeppelinBall -------------------------------> OK NNLS (with VolumeFractions and StickZeppelinBall)+ regularization term ---> OK