search

daducci / COMMIT

Linear framework to combine tractography and tissue micro-structure estimation with diffusion MRI
Other
43 stars 33 forks source link

Mini fix build #82

Closed frheault closed 3 years ago

frheault commented 4 years ago

Small mistake due to inverted condition that was making singularity crash. Simply fix for that, now fully tested with singularity.

frheault commented 3 years ago

@daducci So is that appropriate behavior?

daducci commented 3 years ago

I think this is not a problem for the normal usage (ie without specifying the build_dir). @MarioOcampo can you confirm? Could this be an issue for your application in a cluster environment (running COMMIT by changing the model in the same python instance, within a build_dir)? Sorry but I cannot test that

MarioOcampo commented 3 years ago

The normal use (without specifying the build_dir) is OK, the file is updated as it is in the actual version. Changing the model in the same python instance using build_dir is not supported, the PR displays a warning about this. Only the first compilation is executed correctly.

frheault commented 3 years ago

I think this is clearer and safer than before. It should work fine unless someone wants it to fail and ignore warning.