search

daedalus4096 / PrimalMagick

Harness the magick of the primal sources of the land.
MIT License
9 stars 11 forks source link

Close marble generation gap at 60-64 #239

Closed dreamlibrarian closed 10 months ago

dreamlibrarian commented 11 months ago

Looking at this, is there a reason to have a gap here? Felt weird.

daedalus4096 commented 11 months ago

I'm torn on whether to accept this. On the one hand, yes, the gap is intentional for both marble and rock salt. On the other, it's not for a reason I can really justify. It's exists because the same gap exists for other similar stone types in vanilla; specifically andesite, diorite, and granite. I wouldn't be at all surprised if there's some "here there be dragons" reason why Mojang chose to leave that gap, like plagued their chasm carvers for years (and might still!), and I have no idea how to conclusively prove to my satisfaction that there isn't. I know it's a little weird and cowardly, but for the time being I'm leaning toward "if it ain't broke, don't fix it". I'll think on it, though.

dreamlibrarian commented 11 months ago

Mm, if this is following a model common to other media in vanilla, I'd lean towards matching them.

My guess is that vein size might stretch down or up to meet.

daedalus4096 commented 10 months ago

After thinking through this further, I've decided to reject this PR for the sake of maintaining consistency with vanilla. I appreciate the effort to improve things, though. Thanks!