daedalus4096 / PrimalMagick

Harness the magick of the primal sources of the land.
MIT License
9 stars 11 forks source link

[Crash] Treefolk fertilizing Regions Unexplored Alpha Grass #274

Closed Fiamat closed 2 months ago

Fiamat commented 4 months ago

When the treefolk fertilizes Alpha Grass from Regions Unexplored it oftentimes results in a crash. Using Primal Magick 4.0.9 and RU 0.5.5 (both newest at the time of writing). Tested on both multiplayer server and singleplayer world. No such situation happens when I use bonemeal on the Alpha Grass (often Alpha Grass requires more than one bonemeal to produce anything and does not create grass around the given block; maybe there's the problem).

Steps to reproduce: 1) Create/find a patch of Alpha Grass from Regions Unexplored. 2) Spawn a treefolk and wait for it to fertilize the terrain (possibly more than once; occasionally works as intended)

Result:

Expected result:

Crash log: crash-2024-07-03_13.06.07-server.txt

daedalus4096 commented 4 months ago

Thank you for the report. I'll investigate the crash when I get a chance and try to fix the underlying issue. In the meantime, you should be able to work around this by using a datapack to add the Alpha Grass to the "treefolk_fertilize_exempt" tag, which you can find in /data/primalmagick/tags/blocks.

Fiamat commented 4 months ago

That's a neat and clean workaround, thank you and good luck!

daedalus4096 commented 2 months ago

I've done some investigating, and I don't believe the root cause of this bug to be on Primal Magick's side. I could always be wrong, but nothing is jumping out at me. As such, I've reported the bug to the authors of Regions Unexplored and added Alpha Grass to the treefolks' base "do not fertilize" list to prevent the issue from happening further in the wild. Thank you for the report!