daelsepara / legendary-kingdoms

An Implementation of Legendary Kingdoms gamebook series in C++ and SDL. Only book 1, The Valley of Bones has been implemented as of now.
GNU General Public License v3.0
6 stars 2 forks source link

Game crashes at "The Valley of Bones 496" #2

Open narzalus opened 1 year ago

narzalus commented 1 year ago

When choosing "Give the monkeys an item" the game crashes at "The Valley of Bones 496". (Windows 7)

(Btw just stumbled upon your work today and love what you did with the Legendary Kingdoms gamebook!)

daelsepara commented 1 year ago

Hi. Thanks for reporting. What was the error message when it crashed? Do you have a copy of your save file? I don't think you can send it here as an attachment but in any case, I'll try to replicate it.

narzalus commented 1 year ago

Hi Dael,

thank you for your message! Wasn't sure if you're still working on the project.

Unfortunately I can't send you the save file, as I don't know which save it is. That's another problem/error: When having more than 6 saves (or I don't know which number - I have 159 saves... so maybe that's too much) the loading/saving screen only shows the last 6 saves. You can scroll through all the saves, because the errors on the right side show so - but it still shows the initial 6 saves. So if you're looking to load a save thats later than the last 6 saves I have to count for every scroll down and click on the last/6th save thats shown - hope you know what I mean.

Anyway, trying to reply directly via e-mail here, don't know if it's possible to send an attachment

I found a few other bugs, but can't replicate it as I don't find the save anymore (it's too far gone to scroll blindly through it ; ). Don't know if it helps if I describe it in-game for you?

That's what I found so far.

On 14.08.2022 03:31, Dael wrote:

Hi. Thanks for reporting. What was the error message when it crashed? Do you have a copy of your save file? I don't think you can send it here as an attachment but in any case, I'll try to replicate it.

— Reply to this email directly, view it on GitHub https://github.com/daelsepara/legendary-kingdoms/issues/2#issuecomment-1214262402, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2QICNPTEG3MMBW4YKFGH7DVZBD55ANCNFSM56OI6ASA. You are receiving this because you authored the thread.Message ID: @.***>

narzalus commented 1 year ago

Ok, trying it here again: It seems screenshot is possible, but it won't upload a .save-file.

2022-08-14_09-17-36 :

narzalus commented 1 year ago

But I could just paste what's in my last save:

{"army":[{"deployed":false,"garrison":6,"maximumMorale":3,"maximumStrength":3,"morale":3,"name":"Kensai Warriors","position":-1,"status":0,"statusDuration":0,"statusRound":-1,"strength":3,"type":15,"unique":false},{"deployed":false,"garrison":6,"maximumMorale":4,"maximumStrength":1,"morale":4,"name":"Chalice Archers","position":-1,"status":0,"statusDuration":0,"statusRound":-1,"strength":1,"type":9,"unique":false},{"deployed":false,"garrison":6,"maximumMorale":4,"maximumStrength":4,"morale":4,"name":"Kensai Warriors","position":-1,"status":0,"statusDuration":0,"statusRound":-1,"strength":4,"type":11,"unique":false},{"deployed":false,"garrison":6,"maximumMorale":3,"maximumStrength":2,"morale":3,"name":"Chalice Archers","position":-1,"status":0,"statusDuration":0,"statusRound":-1,"strength":2,"type":1,"unique":false},{"deployed":false,"garrison":6,"maximumMorale":2,"maximumStrength":5,"morale":2,"name":"Lhasbreath Berserkers","position":-1,"status":0,"statusDuration":0,"statusRound":-1,"strength":5,"type":13,"unique":false}],"book":1,"codes":[{"code":3,"type":1},{"code":5,"type":1},{"code":6,"type":1},{"code":7,"type":1},{"code":8,"type":1},{"code":9,"type":1},{"code":10,"type":1},{"code":11,"type":1},{"code":12,"type":1},{"code":14,"type":1},{"code":15,"type":1},{"code":16,"type":1},{"code":18,"type":1},{"code":19,"type":1},{"code":20,"type":1},{"code":21,"type":1},{"code":24,"type":1},{"code":25,"type":1},{"code":26,"type":1},{"code":27,"type":1},{"code":29,"type":1},{"code":30,"type":1},{"code":31,"type":1},{"code":34,"type":1},{"code":35,"type":1},{"code":36,"type":1},{"code":38,"type":1},{"code":40,"type":1},{"code":41,"type":1},{"code":45,"type":1},{"code":46,"type":1},{"code":47,"type":1},{"code":48,"type":1},{"code":51,"type":1},{"code":54,"type":1},{"code":55,"type":1},{"code":56,"type":1},{"code":57,"type":1},{"code":62,"type":1},{"code":64,"type":1},{"code":65,"type":1},{"code":67,"type":1},{"code":68,"type":1},{"code":77,"type":1},{"code":82,"type":1},{"code":84,"type":1},{"code":85,"type":1},{"code":91,"type":1},{"code":92,"type":1},{"code":93,"type":1},{"code":99,"type":1},{"code":61,"type":1}],"currentCharacter":-1,"currentShip":-1,"dead":[],"epoch":1660429833962,"fleet":[{"cargo":[],"fighting":4,"health":7,"location":3,"maximumCargo":2,"maximumHealth":7,"name":"Cog","type":0}],"hearts":[[1,5,1],[5,1,1]],"invisibleCodes":[2,8,52,9,14,53,20,34,17,30,25,50],"lastSelected":3,"lastSelection":[3,0],"limit":4,"location":37,"members":[{"attributes":[{"type":1,"value":6},{"type":2,"value":3},{"type":3,"value":3},{"type":4,"value":2},{"type":5,"value":3}],"background":"Sar Jessica Dayne is a first-born knight of Royce. Her father, Baron Baldwin Dayne, is an ambitious contender for the rulership of Longport Bay, an important county. She is a powerful warrior, of impeccable noble blood, but she has received little love or affection since the death of her mother when Jessica was a girl. She is due to inherit the barony in preference to her younger brother, Ridley, but has clashed with her father in recent years, putting her inheritance in doubt. Sar Jessica hopes to become a rich and important woman in her own right before confronting her father at Fosterly Castle.","damaged":false,"equipment":[{"additionalSlots":0,"attribute":6,"class":4,"description":"shield","modifier":2,"name":"shield","twoHanded":false,"type":3,"value":0},{"additionalSlots":0,"attribute":1,"class":1,"description":"steel scimitar","modifier":2,"name":"steel scimitar","twoHanded":false,"type":83,"value":0},{"additionalSlots":0,"attribute":0,"class":0,"description":"seal of House Ross","modifier":0,"name":"seal of House Ross","twoHanded":false,"type":19,"value":0},{"additionalSlots":0,"attribute":6,"class":2,"description":"bronze armour","modifier":4,"name":"bronze armour","twoHanded":false,"type":44,"value":0},{"additionalSlots":0,"attribute":2,"class":0,"description":"soft boots","modifier":1,"name":"soft boots","twoHanded":false,"type":45,"value":0},{"additionalSlots":0,"attribute":0,"class":0,"description":"talisman of St. Elias","modifier":0,"name":"talisman of St. Elias","twoHanded":false,"type":28,"value":0},{"additionalSlots":0,"attribute":3,"class":0,"description":"reference book","modifier":1,"name":"reference book","twoHanded":false,"type":46,"value":0},{"additionalSlots":0,"attribute":5,"class":0,"description":"glittering necklace","modifier":2,"name":"glittering necklace","twoHanded":false,"type":64,"value":0},{"additionalSlots":0,"attribute":4,"class":0,"description":"warm cloak","modifier":1,"name":"warm cloak","twoHanded":false,"type":47,"value":0},{"additionalSlots":0,"attribute":1,"class":1,"description":"iron greataxe","modifier":2,"name":"iron greataxe","twoHanded":true,"type":37,"value":0}],"followers":[],"health":3,"image":"images/characters/sar-jessica-dayne.png","isCivilized":true,"maximumEquipment":10,"maximumHealth":8,"name":"Sar Jessica Dayne","spellBook":[],"spellBookLimit":6,"spellCaster":false,"status":[],"team":0,"type":1},{"attributes":[{"type":1,"value":3},{"type":2,"value":3},{"type":3,"value":4},{"type":4,"value":4},{"type":5,"value":1}],"background":"Amelia is the half-sister of Jessica and grew up with her in Fosterly Castle. Her mother was a forester who took Amelia away from the castle when it became obvious that Baron Baldwin, her father, would take no interest in the girl. Since maturity Amelia has lived in the wild forests of the Savage Lands, learning earth magic from the druids of that isolated place. Though slender, she has become a rugged survivor, who can live off the land and fight off wild beasts. Her magic is instinctive, and much mocked by more scholarly wizards, but it is no less potent for all that. Amelia dreams of becoming a full-circle druid, but knows that she must learn much before returning home to the Savage Lands.","damaged":false,"equipment":[{"additionalSlots":0,"attribute":6,"class":4,"description":"shield","modifier":2,"name":"shield","twoHanded":false,"type":3,"value":0},{"additionalSlots":0,"attribute":0,"class":0,"description":"bluestone","modifier":0,"name":"bluestone","twoHanded":false,"type":4,"value":0},{"additionalSlots":0,"attribute":0,"class":0,"description":"hygliph flower","modifier":0,"name":"hygliph flower","twoHanded":false,"type":7,"value":0},{"additionalSlots":0,"attribute":0,"class":0,"description":"silver skull","modifier":0,"name":"silver skull","twoHanded":false,"type":34,"value":0},{"additionalSlots":0,"attribute":4,"class":0,"description":"warm cloak","modifier":1,"name":"warm cloak","twoHanded":false,"type":47,"value":0},{"additionalSlots":0,"attribute":3,"class":0,"description":"tome of knowledge","modifier":2,"name":"tome of knowledge","twoHanded":false,"type":72,"value":0},{"additionalSlots":0,"attribute":6,"class":2,"description":"bone armour","modifier":2,"name":"bone armour","twoHanded":false,"type":43,"value":0},{"additionalSlots":0,"attribute":1,"class":1,"description":"steel longsword","modifier":2,"name":"steel longsword","twoHanded":false,"type":38,"value":0},{"additionalSlots":0,"attribute":5,"class":0,"description":"handsome brooch","modifier":1,"name":"handsome brooch","twoHanded":false,"type":48,"value":0},{"additionalSlots":0,"attribute":2,"class":0,"description":"soft boots","modifier":1,"name":"soft boots","twoHanded":false,"type":45,"value":0}],"followers":[],"health":3,"image":"images/characters/amelia-pass-dayne.png","isCivilized":true,"maximumEquipment":10,"maximumHealth":6,"name":"Amelia Pass-Dayne","spellBook":[{"charged":true,"description":"You are able to communicate using the secret speech of animals.","name":"Animal Speech","recharge":50,"scope":1,"type":0},{"charged":true,"description":"A pillar of energy sizzles into a single foe. Choose an opponent to lose 3 Health.","name":"Unfailing Strike","recharge":50,"scope":2,"type":4},{"charged":true,"description":"Your hands glow with divine energy. Choose one of your party members; they can restore 5 Health points.","name":"Soothing Touch","recharge":50,"scope":5,"type":12},{"charged":true,"description":"Doubt and uncertainty fill the hearts of the enemy soldiers. Reduce the Morale score of an enemy unit by 1 point.","name":"Clinging Dread","recharge":50,"scope":3,"type":18},{"charged":true,"description":"Gain a +3 bonus to one party member's Armour which lasts until the end of this battle.","name":"Armour of Heaven","recharge":50,"scope":2,"type":1},{"charged":true,"description":"Your mind awakens with ancient knowledge. Cast this spell when you have failed a Lore check. You gain 3 automatic successes for this check only.","name":"Wisdom","recharge":75,"scope":6,"type":7}],"spellBookLimit":6,"spellCaster":true,"status":[],"team":0,"type":4},{"attributes":[{"type":1,"value":5},{"type":2,"value":3},{"type":3,"value":3},{"type":4,"value":8},{"type":5,"value":1}],"background":"Akihiro is a brooding young man from the Valley of Bones, who was banished from his city when he failed in his training to become a Kensai, a sword-saint of Chalice. A superb swordsman, Akihiro is his own worst enemy. He tortures himself over his failure to balance his mind and body. Since that time Akihiro has become an adept survivor, able to find water in the driest desert, and food in an empty wilderness. Though he tells himself he has given up, he longs in his heart to return to Chalice to attempt the tests again. Perhaps it is time for Akihiro to emerge from the wilderness and restore his own and his family's honour?","damaged":false,"equipment":[{"additionalSlots":0,"attribute":6,"class":2,"description":"bone armour","modifier":2,"name":"bone armour","twoHanded":false,"type":43,"value":0},{"additionalSlots":0,"attribute":2,"class":0,"description":"soft boots","modifier":1,"name":"soft boots","twoHanded":false,"type":45,"value":0},{"additionalSlots":0,"attribute":1,"class":1,"description":"steel longsword","modifier":2,"name":"steel longsword","twoHanded":false,"type":38,"value":0},{"additionalSlots":0,"attribute":4,"class":3,"description":"rugged cloak","modifier":2,"name":"rugged cloak","twoHanded":false,"type":60,"value":0},{"additionalSlots":0,"attribute":0,"class":0,"description":"dragonyak horn","modifier":0,"name":"dragonyak horn","twoHanded":false,"type":30,"value":0},{"additionalSlots":0,"attribute":6,"class":4,"description":"shield","modifier":2,"name":"shield","twoHanded":false,"type":3,"value":0},{"additionalSlots":0,"attribute":3,"class":0,"description":"reference book","modifier":1,"name":"reference book","twoHanded":false,"type":46,"value":0},{"additionalSlots":0,"attribute":0,"class":0,"description":"bluestone","modifier":0,"name":"bluestone","twoHanded":false,"type":4,"value":0},{"additionalSlots":0,"attribute":5,"class":0,"description":"handsome brooch","modifier":1,"name":"handsome brooch","twoHanded":false,"type":48,"value":0}],"followers":[],"health":4,"image":"images/characters/akihiro-of-chalice.png","isCivilized":true,"maximumEquipment":10,"maximumHealth":8,"name":"Akihiro of Chalice","spellBook":[],"spellBookLimit":6,"spellCaster":false,"status":[1,7],"team":0,"type":5},{"attributes":[{"type":1,"value":4},{"type":2,"value":7},{"type":3,"value":3},{"type":4,"value":1},{"type":5,"value":7}],"background":"Brash was born in Royce, in the duchy of Pendrilor. He was a pot washer in Vasthall, the stately home of Duchess Elenor Mauntell, but unwisely engaged in a love triangle with her and King Frances Goldwell. Fleeing before he could be hung, Brash has since lived on his wits, travelling the world to escape the King's agents. He can talk his way out of almost anything, and his ability to escape danger is second-to-none. One day, Brash will need to sort out the mess he left behind in Vasthall, but not until he has gained a little worldly experience.","damaged":false,"equipment":[{"additionalSlots":0,"attribute":0,"class":0,"description":"iron sceptre","modifier":0,"name":"iron sceptre","twoHanded":false,"type":51,"value":0},{"additionalSlots":0,"attribute":2,"class":0,"description":"fine boots","modifier":2,"name":"fine boots","twoHanded":false,"type":21,"value":0},{"additionalSlots":0,"attribute":6,"class":4,"description":"shield","modifier":2,"name":"shield","twoHanded":false,"type":3,"value":0},{"additionalSlots":0,"attribute":0,"class":0,"description":"bluestone","modifier":0,"name":"bluestone","twoHanded":false,"type":4,"value":0},{"additionalSlots":0,"attribute":1,"class":1,"description":"steel scimitar","modifier":2,"name":"steel scimitar","twoHanded":false,"type":83,"value":0},{"additionalSlots":0,"attribute":6,"class":2,"description":"bone armour","modifier":2,"name":"bone armour","twoHanded":false,"type":43,"value":0},{"additionalSlots":0,"attribute":0,"class":0,"description":"bluestone","modifier":0,"name":"bluestone","twoHanded":false,"type":4,"value":0},{"additionalSlots":0,"attribute":5,"class":0,"description":"glittering necklace","modifier":2,"name":"glittering necklace","twoHanded":false,"type":64,"value":0},{"additionalSlots":0,"attribute":0,"class":0,"description":"iron key","modifier":0,"name":"iron key","twoHanded":false,"type":79,"value":0},{"additionalSlots":0,"attribute":0,"class":0,"description":"grey talisman","modifier":0,"name":"grey talisman","twoHanded":false,"type":23,"value":0}],"followers":[],"health":5,"image":"images/characters/brash.png","isCivilized":true,"maximumEquipment":10,"maximumHealth":8,"name":"Brash","spellBook":[],"spellBookLimit":6,"spellCaster":false,"status":[],"team":0,"type":6}],"money":3302,"order":[6,4,1,5],"recentSuccesses":6,"storyID":341,"vault":[],"vaultMoney":0}

narzalus commented 1 year ago

PS: Found a solution for the spell as I just changed the spell/equipment limit in the save and added the other spells manually from a new save ; )

narzalus commented 1 year ago

Another bug: There's a sword called Skallos Runeblade, it should give +3 fighting skill and +2 lore. But it only gives +3 fighting.

{"additionalSlots":0,"attribute":9,"class":1,"description":"skallos runeblade","modifier":3,"name":"skallos runeblade","twoHanded":false,"type":74,"value":0}

daelsepara commented 1 year ago

Thanks! Will try and fix these. Thanks for the reporting all the bugs and annoyances you have found. They sound pretty serious (or at least pretty annoying). Thanks for sending over in the comments, the save files. They're gonna be useful.

regarding your fix for the spell limit. I would have done the same, I think