daem-on / wtherion

A web-based Therion map editor
https://daem-on.github.io/wtherion/
MIT License
17 stars 2 forks source link

station name (reference) should always auto increase or inherit xvi station name #15

Open CaverBruce opened 2 years ago

CaverBruce commented 2 years ago

The Tools reference https://github.com/daem-on/wtherion/wiki/Tools%20reference says: " If this contains a @ character, the number before it will automatically increase." and indeed this is the behaviour I observe. However it is almost never the case that multiple stations with the same name (station reference) will be entered sequentially, so the station name should always auto increase. The referencing to a survey using @ should not be relevant to the behaviour. Except when the new station point is created within a reasonable snapping distance of an xvi station point. In these cases the station point should snap to and inherit the station name from the xvi station point.

daem-on commented 2 years ago

Sure, I'll implement this. I originally only implemented it with the @ character because I didn't think anybody would use names without it. But not hard to change anyway.

The XVI part is already implemented as you have described.

CaverBruce commented 2 years ago

Thanks for the auto station number increase. This now works as expected, although only for numeric integers. All other options do not increase.

Just a comment on point stations created by snapping onto an xvi station. It does work, as you say (snaps to centre and inherits xvi station name) however the point station seems to sit underneath the xvi image, and so is completely invisible. Or perhaps the colours are so well blended that I cannot see the yellow-orange station over the larger xvi dot. The 'point station under xvi' is not identified by the inspect tool, only the xvi station is, leading to my conjecture that it is under the xvi, despite being drawn after the xvi. image It can be detected by selecting a box over the xvi station, and then its properties are exposed. However, because it is generally invisible, I find myself adding multiple points, because I think I mis-clicked, or later on I forget, and add another point station.