search

daemionfox / patreon-feed

Patreon RSS library based on Patreon's API
41 stars 6 forks source link

[WIP] RSS Feed for personal Patreon Feed #2

Closed criztovyl closed 6 years ago

criztovyl commented 6 years ago

As of #1, here the PR for that.

One-liner to test:

$ php -r 'require("vendor/autoload.php"); $patreon = new \daemionfox\Patreon\PatreonRSS(); \
$patreon->login("'"$PATREON_MAIL"'", "'"$PATREON_PASS"'"); echo $patreon->rss();'`

As you can see, currently only PatreonRSS is integrated, I am currently working on integrating it into the Feed class. :)

I use PHP Streams to obtain the required Session ID and the Patreon Stream, for this small use-case I thought no Guzzle or equivalent is needed. If you want I can change that to Guzzle, I'm open for that.

Thank you.

Closes #1.

criztovyl commented 6 years ago

I just changed my mind about the streams, as I would add some tests for what I will implement and mocking Guzzle seems to be more straight forward than mocking PHP Streams.

Let me know what you think about that. :)

daemionfox commented 6 years ago

Looks good. Nice solid code (that, also fits in really well with other libraries I like to use, so joy). I've incremented this as a major release, with a 1.0. Thanks for the contrib!

criztovyl commented 6 years ago

But I wasn't ready yet :P (That's why I've put WIP into the title ^^) It does not break anything, but isn't as complete as I want it to be.

I'll continue my work, lets see if I can re-use this PR or need to open a new one. :)