search

daemitus / SomethingNeedDoing

89 stars 64 forks source link

Assign macro to button? #17

Closed ripdog closed 2 years ago

ripdog commented 2 years ago

Thanks for this addon, it really fills the gaps in the macro system gooooood!

But it'd be great if the macros could be assigned to an action bar button like a normal macro. I guess the easy way to do this is to modify the /pcraft command to accept an argument of a macro name.

daemitus commented 2 years ago

added. look at /pcraft help for the cli info.

ripdog commented 2 years ago

Thanks so much, @daemitus ! However, I haven't been able to get it to work. See screenshot: https://i.imgur.com/wcN1boD.png

At first the macro name had spaces, so I renamed it to remove them, but still no luck. Any advice?

Here's my plugin config if it's helpful: SomethingNeedDoing.zip

daemitus commented 2 years ago

thanks, ill take a look as to whats going on.

On Mon, Dec 27, 2021 at 11:18 AM ripdog @.***> wrote:

Thanks so much, @daemitus https://github.com/daemitus ! However, I haven't been able to get it to work. See screenshot: https://i.imgur.com/wcN1boD.png

At first the macro name had spaces, so I renamed it to remove them, but still no luck. Any advice?

Here's my plugin config if it's helpful: SomethingNeedDoing.zip https://github.com/daemitus/SomethingNeedDoing/files/7780932/SomethingNeedDoing.zip

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/17#issuecomment-1001640814, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBFUZ3DROB5F7HB5AMLUTCGVRANCNFSM5KUB3XGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

daemitus commented 2 years ago

oh i fucked it up. i had it as "runmacro" and was slicing off the first 9 characters. now its run and still 9 characters.

On Mon, Dec 27, 2021 at 11:49 AM Raymond Lynch @.***> wrote:

thanks, ill take a look as to whats going on.

On Mon, Dec 27, 2021 at 11:18 AM ripdog @.***> wrote:

Thanks so much, @daemitus https://github.com/daemitus ! However, I haven't been able to get it to work. See screenshot: https://i.imgur.com/wcN1boD.png

At first the macro name had spaces, so I renamed it to remove them, but still no luck. Any advice?

Here's my plugin config if it's helpful: SomethingNeedDoing.zip https://github.com/daemitus/SomethingNeedDoing/files/7780932/SomethingNeedDoing.zip

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/17#issuecomment-1001640814, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBFUZ3DROB5F7HB5AMLUTCGVRANCNFSM5KUB3XGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

daemitus commented 2 years ago

pushing a fix, re-open if the issue persists please.

On Mon, Dec 27, 2021 at 11:51 AM Raymond Lynch @.***> wrote:

oh i fucked it up. i had it as "runmacro" and was slicing off the first 9 characters. now its run and still 9 characters.

On Mon, Dec 27, 2021 at 11:49 AM Raymond Lynch @.***> wrote:

thanks, ill take a look as to whats going on.

On Mon, Dec 27, 2021 at 11:18 AM ripdog @.***> wrote:

Thanks so much, @daemitus https://github.com/daemitus ! However, I haven't been able to get it to work. See screenshot: https://i.imgur.com/wcN1boD.png

At first the macro name had spaces, so I renamed it to remove them, but still no luck. Any advice?

Here's my plugin config if it's helpful: SomethingNeedDoing.zip https://github.com/daemitus/SomethingNeedDoing/files/7780932/SomethingNeedDoing.zip

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/17#issuecomment-1001640814, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBFUZ3DROB5F7HB5AMLUTCGVRANCNFSM5KUB3XGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ripdog commented 2 years ago

Brilliant, works great. Thanks!

On Tue, Dec 28, 2021 at 5:56 AM Raymond @.***> wrote:

pushing a fix, re-open if the issue persists please.

On Mon, Dec 27, 2021 at 11:51 AM Raymond Lynch @.***> wrote:

oh i fucked it up. i had it as "runmacro" and was slicing off the first 9 characters. now its run and still 9 characters.

On Mon, Dec 27, 2021 at 11:49 AM Raymond Lynch @.***> wrote:

thanks, ill take a look as to whats going on.

On Mon, Dec 27, 2021 at 11:18 AM ripdog @.***> wrote:

Thanks so much, @daemitus https://github.com/daemitus ! However, I haven't been able to get it to work. See screenshot: https://i.imgur.com/wcN1boD.png

At first the macro name had spaces, so I renamed it to remove them, but still no luck. Any advice?

Here's my plugin config if it's helpful: SomethingNeedDoing.zip < https://github.com/daemitus/SomethingNeedDoing/files/7780932/SomethingNeedDoing.zip

— Reply to this email directly, view it on GitHub < https://github.com/daemitus/SomethingNeedDoing/issues/17#issuecomment-1001640814 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAFMTBFUZ3DROB5F7HB5AMLUTCGVRANCNFSM5KUB3XGA

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/17#issuecomment-1001655024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABKWYE5VFKPLIY7253RGDDUTCLEPANCNFSM5KUB3XGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>