daemitus / SomethingNeedDoing

91 stars 64 forks source link

Loop functionality changed? #20

Closed calmcacil closed 2 years ago

calmcacil commented 2 years ago

Did loop functionality change in a recent update? using on loop for 10 loops, stops it after the 10 crafts, with the log out put of 1 loop remaining. I dont really mind the change of making the loop number be the amount of crafts wanted but if its the case you probably wanna -1 on loops remaining for the output.

daemitus commented 2 years ago

I had reports of it being wonky. Can you link your macro?

This is what ive been using to test.

/echo abc <wait.2>
/loop 2 <echo>

resulting in

abc
[SND] 2 loops remaining
abc
[SND] 1 loop remaining
abc
[SND] 0 loops remaining

On Mon, Dec 27, 2021 at 3:18 PM Calmcacil @.***> wrote:

Did loop functionality change in a recent update? using on loop for 10 loops, stops it after the 10 crafts, with the log out put of 1 loop remaining. I dont really mind the change of making the loop number be the amount of crafts wanted but if its the case you probably wanna -1 on loops remaining for the output.

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/20, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBB2MGRETTIYBR7HHCLUTDCYHANCNFSM5K247Q2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

calmcacil commented 2 years ago

I was using this to mass craft some of the new furniture for my house.

/click synthesize /waitaddon "Synthesis" /ac Veneration /ac Groundwork /ac Groundwork /ac Groundwork /waitaddon "RecipeNote" /loop 10

stops at 1 remaining and clears the queue, no error in chat.

daemitus commented 2 years ago

yeah, im bad at this. ill fix it shortly.

On Mon, Dec 27, 2021 at 3:30 PM Calmcacil @.***> wrote:

I was using this to mass craft some of the new furniture for my house.

/click synthesize /waitaddon "Synthesis" /ac Veneration /ac Groundwork /ac Groundwork /ac Groundwork /waitaddon "RecipeNote" /loop 10

stops at 1 remaining and clears the queue, no error in chat.

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/20#issuecomment-1001741782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBA43UZ3W2R4IYTI623UTDEFFANCNFSM5K247Q2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

daemitus commented 2 years ago

1.2.1.5 should fix this. re-open if i have continued to be dumb.