search

daemitus / SomethingNeedDoing

91 stars 64 forks source link

endless loops never stop #32

Closed LastExceed closed 2 years ago

LastExceed commented 2 years ago

i tried 

/ac "Summon Carbuncle"
/loop

on SMN for testing purposes, and cannot figure out how to make it stop. neither the stop button, nor the commands /pcraft stop and /pcraft stop loop work. the only way i found was uninstalling the plugin

daemitus commented 2 years ago

🤷 works fine for me.

/pcraft run test /pcraft stop

/echo test1 <wait.2>
/echo test2 <wait.2>
/echo test3 <wait.2>
/loop
LastExceed commented 2 years ago

maybe try reproducing with the exact same macro i used?

daemitus commented 2 years ago

The "send to chat" part of this uses a queue that schedules each /ac to be sent on the next tick. Because there is no wait, and you absolutely need a wait for any /ac command, it sent a bunch of stuff into the queue. This has been fixed, when you stop or pause the chat queue is now cleared.

LastExceed commented 2 years ago

ah yes i understand. thanks for the explanation and quick fix!