daemitus / SomethingNeedDoing

89 stars 64 forks source link

[Feature requests] Automatic repair #33

Closed PotatoSol closed 2 years ago

PotatoSol commented 2 years ago

Would allow for macros like

/click synthesize /ac [crafting macro] /loop 100 /repair /loop

(edit: this actually wouldn't work cus you can't run a loop in the middle of a macro so that would also need to be updated)

daemitus commented 2 years ago

you actually can. each loop is tracked separately. i think i'd just have to tweak the loop logic a little to reset itself after reaching the max loop value.

ANYWAYS. an explicit /repair command will probably never happen. however separate /click commands could potentially be developed if I ever had the time to do it. The hardest problem is opening the repair window without going through the inventory item context menu. I dont think theres a native /command to open that window normally.

PotatoSol commented 2 years ago

I think you could just leave the repair window up throughout the entire craft and then just do /click "repair all", it'd be a little clunky but functional

anyways, thanks for the plugin definitely my favorite one i've used!

On Fri, Jan 14, 2022 at 4:38 PM Raymond @.***> wrote:

you actually can. each loop is tracked separately. i think i'd just have to tweak the loop logic a little to reset itself after reaching the max loop value.

ANYWAYS. an explicit /repair command will probably never happen. however separate /click commands could potentially be developed if I ever had the time to do it. The hardest problem is opening the repair window without going through the inventory item context menu. I dont think theres a native /command to open that window normally.

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/33#issuecomment-1013491194, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANGBNRGRL4X446CQ77JMP3UWCJVFANCNFSM5L6EIOCA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

trini0n commented 2 years ago

Just a thought, but maybe you could have settings to set a hotkey for the gear repair shortcut and if someone initiates /repair, it'll send the keystroke to open the menu?

daemitus commented 2 years ago

half the problem too, is you cant repair while crafting/kneeling. So you need to back out of the menu, which loses your recipe spot :(

On Fri, Jan 14, 2022 at 8:53 PM Brandon @.***> wrote:

Just a thought, but maybe you could have settings to set a hotkey for the gear repair shortcut and if someone initiates /repair, it'll send the keystroke to open the menu?

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/33#issuecomment-1013579890, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBH7XPVGXLYDUKIJ5VTUWDHRDANCNFSM5L6EIOCA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

PotatoSol commented 2 years ago

https://github.com/Saad888/AutoSynthesis

This is a different program that I used before switching to yours that allows you to use food/pot when it ran out, and you can't do those while crafting/kneeling either. I'm not 100% sure, but I think it works by having you start a craft and then cancel the craft, so that you stand up. As long as you don't do any actions in a craft, all the mats are refunded. From here, you can click "repair all -> yes" and then "synthesize" again without closing any important windows

daemitus commented 2 years ago

there's now a /click repair_all and /click synthesis_quit. Also, nested looping should be fixed. If you combine this with YesAlready or do the /click select_yes yourself, along with some /waitaddon commands, you should be able to do it manually for now.

PotatoSol commented 2 years ago

Works great! Thanks!

On Sun, Jan 16, 2022 at 7:17 PM Raymond @.***> wrote:

there's now a /click repair_all and /click synthesis_quit. Also, nested looping should be fixed. If you combine this with YesAlready or do the /click select_yes yourself, along with some /waitaddon commands, you should be able to do it manually for now.

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/33#issuecomment-1013987673, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANGBNSJNHT7ZMFVHTJLWGLUWNNZTANCNFSM5L6EIOCA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>