The Macro Editor does not display Japanese characters.

[marimelon]

The Macro Editor does not display Japanese characters.

[rlynch-ironnet]

do you know of a monospaced font that does jp symbols?

[marimelon]

"Noto Sans Mono CJK JP" is famous. This width ratio is alphabet : Japanese = 1:2

[marimelon]

my idea

fonts : https://noto-website-2.storage.googleapis.com/pkgs/NotoSansCJKjp-hinted.zip

public void UiBuilder_OnBuildFonts()
{
    var fontData = SomethingNeedDoingPlugin.ReadResource("SomethingNeedDoing.Fonts.ProggyVectorRegular.ttf");
    var fontPtr = Marshal.AllocHGlobal(fontData.Length);
    Marshal.Copy(fontData, 0, fontPtr, fontData.Length);

    var JPfontData = SomethingNeedDoingPlugin.ReadResource("SomethingNeedDoing.Fonts.NotoSansMonoCJKtc-Regular.otf");
    var JPfontPtr = Marshal.AllocHGlobal(JPfontData.Length);
    Marshal.Copy(JPfontData, 0, JPfontPtr, JPfontData.Length);

    unsafe{
        ImFontConfigPtr fontConfig = ImGuiNative.ImFontConfig_ImFontConfig();
        fontConfig.MergeMode = true;
        fontConfig.PixelSnapH = true;

        ProggyVectorFont = ImGui.GetIO().Fonts.AddFontFromMemoryTTF(fontPtr, fontData.Length, plugin.Configuration.CustomFontSize, fontConfig);

        // Set Japanese Font GlyphRanges
        // Copy from
        // https://github.com/goatcorp/Dalamud/blob/master/Dalamud/Interface/GlyphRangesJapanese.cs
        var japaneseRangeHandle = GCHandle.Alloc(GlyphRangesJapanese.GlyphRanges, GCHandleType.Pinned);
        NotoSansMonoFont = ImGui.GetIO().Fonts.AddFontFromMemoryTTF(JPfontPtr, JPfontData.Length, plugin.Configuration.CustomFontSize, fontConfig, japaneseRangeHandle.AddrOfPinnedObject());
        japaneseRangeHandle.Free();
    }
}

// PluginUI.DisplayMacroEdit()
ImGui.PushFont(ProggyVectorFont);
ImGui.PushFont(NotoSansMonoFont);

var contents = node.Contents;
if (ImGui.InputTextMultiline($"##{node.Name}-editor", ref contents, 100_000, new Vector2(-1, -1)))
{
    node.Contents = contents;
    plugin.SaveConfiguration();
}

ImGui.PopFont();
ImGui.PopFont();

[daemitus]

I assume you meant NotoSansMonoCJKjp-Regular.otf and not tc?

[marimelon]

Oh, my mistake.

[marimelon]

I'm not familiar with c#, should we release fontPtr (and JPfontPtr) in Dispose?

[daemitus]

let me see what dalamud does with the default font ptr

[daemitus]

There is no dispose method, I think ImGui handles it.

[daemitus]

Implemented in 1.0.0.10.