daemitus / SomethingNeedDoing

86 stars 59 forks source link

condition not working & garbled double-byte characters #52

Closed Crescr closed 2 years ago

Crescr commented 2 years ago

condition not working & garbled double-byte characters

We use in Japanese environment.

The condition command is recognized but does not work. It will be skipped even in a good or excellent state.

Examples: /ac 集中加工 <condition.good,exllent>

The macro queue successfully displays double-byte characters, but the macro editor displays "????". Copying to the editor and pasting from the editor work fine, but I'd like you to fix it.

daemitus commented 2 years ago

the condition check compares to what is in the synthesis wiindow. does it show up as "good" or as the translated version of that?

The ??? i can work on now. It will end up disabling the monospace font however.

daemitus commented 2 years ago

Try <condition.高品質,最高品質> maybe?

Crescr commented 2 years ago

thank you for your answer.

I tested it below, but I get a syntax error. command: /ac 集中加工 <condition.高品質,最高品質> errormessage: 2番目のターゲット名の指定が正しくありません。: <condition.高品質,最高品質>

If you look at the xldata-addon inspector in the "good" state, it will look like the image. The "Replace text" field is normal, but the "text:" is garbled. I don't know if these are related.

If fixing the font causes other problems It may be appreciated if you can make a selection system in "Options".

clip_2

daemitus commented 2 years ago

The condition modifier checked for a-zA-Z and did not include the JP character range. I think i've got a good fix ready soon.

daemitus commented 2 years ago

Please let me know if 1.2.2.8 fixes your issues. This includes an option to disable monospaced font in the edit window.

Crescr commented 2 years ago

Updated to 1.2.2.8. I have confirmed that all issues have been resolved.

Thank you for the quick response.