search

daemitus / SomethingNeedDoing

86 stars 59 forks source link

Issue with /ac in CN client #65

Closed joesh1n closed 2 years ago

joesh1n commented 2 years ago

Using the CN client, the crafts were being started from the RecipeNote interface normally, however, when it comes to executing any of the /ac lines, there was an error message of "Could not parse progress number in the Synthesis addon: Failure while running /ac X", with X being the name of the action in Chinese, such as 坚信 for Muscle Memory. Using English macro lines simply don't do anything. Is there any workaround for this?

AsterNighT commented 2 years ago

Same issue here. Would provide info for the problem if necessary.

daemitus commented 2 years ago

My best guess is the addon is laid out differently since the patch for your client. I'll need to write up some steps to figure this out from your end

On Tue, Apr 26, 2022, 7:16 AM AsterNighT @.***> wrote:

Same issue here. Would provide info for the problem if necessary.

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/65#issuecomment-1109669518, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBAQ32WLEENGKTOM7T3VG7GCBANCNFSM5UI2T2LQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

daemitus commented 2 years ago

ok.

Screenshot 2022-04-26 172607

daemitus commented 2 years ago

On another note, does using the english names work, or are you required to use the CN ones? does /ac "Muscle Memory" do anything in a regular macro?

RyotaMono commented 2 years ago

In CN client,

for Progress:

for Quality:

It is required to use the CN ones. /ac with English skill name results in a skill not found error.

RyotaMono commented 2 years ago

FYI, the issue may come from the updates in March/April. Old SND client with AseemblyVersion of 1.2.2.7 works fine.

daemitus commented 2 years ago

Does your synthesis window show the collectability numbers, and have the different colored quality bar? It sounds like you haven't gotten the update for it.

On Tue, Apr 26, 2022, 11:28 PM Yunhao Zhao @.***> wrote:

FYI, the issue may come from the updates in March/April. Old SND client before the /craft was introduced works fine.

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/65#issuecomment-1110494317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBBXQD5XLT4JE6GT5EDVHCX6FANCNFSM5UI2T2LQ . You are receiving this because you commented.Message ID: @.***>

RyotaMono commented 2 years ago

Thanks for your quick reply. Sorry, I don't quite understand. What is "the update"? Should I post screenshots of both the FFXIV synthesis window and the SND panel?

Does your synthesis window show the collectability numbers, and have the different colored quality bar? It sounds like you haven't gotten the update for it.

daemitus commented 2 years ago

The 6.1? Game update messed with the synthesis window shifting around some of the numbers and adding new features. I'll grab a screenshot tomorrow.

On Tue, Apr 26, 2022, 11:36 PM Yunhao Zhao @.***> wrote:

Thanks for your quick reply. Sorry, I don't quite understand. What is "the update"? Should I post screenshots of both the FFXIV synthesis window and the SND panel?

Does your synthesis window show the collectability numbers, and have the different colored quality bar? It sounds like you haven't gotten the update for it. … <#m6998750459186086068> On Tue, Apr 26, 2022, 11:28 PM Yunhao Zhao @.> wrote: FYI, the issue may come from the updates in March/April. Old SND client before the /craft was introduced works fine. — Reply to this email directly, view it on GitHub <#65 (comment) https://github.com/daemitus/SomethingNeedDoing/issues/65#issuecomment-1110494317>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBBXQD5XLT4JE6GT5EDVHCX6FANCNFSM5UI2T2LQ https://github.com/notifications/unsubscribe-auth/AAFMTBBXQD5XLT4JE6GT5EDVHCX6FANCNFSM5UI2T2LQ . You are receiving this because you commented.Message ID: @.>

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/65#issuecomment-1110498449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBACYU4MJO5AIIM5Z43VHCY3VANCNFSM5UI2T2LQ . You are receiving this because you commented.Message ID: @.***>

RyotaMono commented 2 years ago

Not yet, there is a 6-month lag between the update of other global clients and the CN client. Currently, the CN client is at version 6.05 (updated at 04/26, yesterday). The 6.0 version was updated only about a month ago.

RyotaMono commented 2 years ago

Thanks so much for your hints, and your time to develop the plugin.

I tried the old AddonSynthesis.cs file before the recent ffxiv update. Link: AddonSynthesis.cs. After replacing lib\FFXIVClientStructs\FFXIVClientStructs\FFXIV\Client\UI\AddonSynthesis.cs with the older one and rebuild the whole project, the problem is solved.

daemitus commented 2 years ago

Ok, i took the old addonsynthesis, built and uploaded as SND 6.05-CN to the repo. It won't get any updates automatically, but is current as of right now.

Let me know if there are any more problems.

yjywybb commented 2 years ago

It seem that you put the same link in Something Need Doing 6.05 CN as Something Need Doing

"Author": "daemitus", "Name": "Something Need Doing 6.05 CN", "Punchline": "Work work.", "Description": "A hard-working peon that crafts what you tell him to. An all-in-one sythesizing solution.", "InternalName": "SomethingNeedDoing", "AssemblyVersion": "1.2.4.4", "RepoUrl": "https://github.com/daemitus/SomethingNeedDoing", "ApplicableVersion": "any", "DalamudApiLevel": 6, "LoadPriority": 0, "IconUrl": "https://github.com/daemitus/SomethingNeedDoing/raw/master/res/icon.png", "ImageUrls": [], "DownloadLinkInstall": "https://github.com/daemitus/MyDalamudPlugins/raw/master/plugins/SomethingNeedDoing/latest.zip", "IsHide": false, "IsTestingExclusive": false, "DownloadLinkTesting": "https://github.com/daemitus/MyDalamudPlugins/raw/master/plugins/SomethingNeedDoing/latest.zip", "DownloadLinkUpdate": "https://github.com/daemitus/MyDalamudPlugins/raw/master/plugins/SomethingNeedDoing/latest.zip", "DownloadCount": 0, "LastUpdate": "1652502386"