daemitus / SomethingNeedDoing

92 stars 67 forks source link

[BUG] HasMaxQuality() function does not function on non-hq able items #95

Open EliEron opened 2 years ago

EliEron commented 2 years ago

When the HasMaxQuality function is used on an item that does not have an HQ version in the game the function malfunctions, likely due to the item not having any HQ% visible while you craft the item. I ran into this issue while crafting Crow Fly as a Goldsmith but any item that has no HQ version suffers from this issue.

Looking at the HasMaxQuality code I see that it already has code for handling this scenario for collectible items, is there a specific reason why the code used for collectible items are not simply used for all items? That would solve the issue in this case.