daemitus / SomethingNeedDoing

87 stars 64 forks source link

[Feature Request] Pause for Materia Extraction only if each piece of gear is either at 100% or below a given threshold #97

Closed keoShine closed 2 years ago

keoShine commented 2 years ago

As /requirespiritbond currently works, looping will always pause for materia extraction if at least two pieces of gear are at 100% spiritbond.. This can be inconvenient if a third piece of gear is about to finish spiritbonding since it requires either stopping to extract materia between crafts multiple separate times or else manually stepping past the /requirespiritbond step a for a few loops.. Since pentamelded gear tends to have 5-10 pieces that are all within 1-2% of each other if they were last Extracted at the same time, it would be more convenient to be able to set a threshold such that the loop will only stop if at least one item is at 100% spiritbond and no items that aren't yet at 100% are above the threshold (e.g., with a threshold of 95%, if Earring, Necklace, Bracelet and Ring 1 are all at 100% and Ring 2 is at 98% due to RNG variance in spiritbond gains, the loop will continue until Ring 2 hits 100% and then pause for Extraction)..

daemitus commented 2 years ago

Doesnt it already do this? or is it bugged out?

On Sat, Sep 3, 2022 at 4:01 PM keoShine @.***> wrote:

As /requirespiritbond currently works, looping will always pause for materia extraction if at least two pieces of gear are at 100% spiritbond.. This can be inconvenient if a third piece of gear is about to finish spiritbonding since it requires either stopping to extract materia between crafts multiple separate times or else manually stepping past the /requirespiritbond step a for a few loops.. Since pentamelded gear tends to have 5-10 pieces that are all within 1-2% of each other if they were last Extracted at the same time, it would be more convenient to be able to set a threshold such that the loop will only stop if at least one item is at 100% spiritbond and no items that aren't yet at 100% are above the threshold (e.g., with a threshold of 95%, if Earring, Necklace, Bracelet and Ring 1 are all at 100% and Ring 2 is at 98% due to RNG variance in spiritbond gains, the loop will continue until Ring 2 hits 100% and then pause for Extraction)..

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/97, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBA7ZEDLU6IQYMMTNLDV4OVBRANCNFSM6AAAAAAQEAWPMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

keoShine commented 2 years ago

I may actually just be complete garbage both at reading and figuring out how things work.. Sorry for misunderstanding it and not assuming it was me just being bad at things..

daemitus commented 1 year ago

:)

On Sat, Sep 3, 2022 at 7:06 PM keoShine @.***> wrote:

I may actually just be complete garbage both at reading and figuring out how things work.. Sorry for misunderstanding it and not assuming it was me just being bad at things..

— Reply to this email directly, view it on GitHub https://github.com/daemitus/SomethingNeedDoing/issues/97#issuecomment-1236211083, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBG76RGKHM4WPRKMHUTV4PKVRANCNFSM6AAAAAAQEAWPMI . You are receiving this because you commented.Message ID: @.***>