search

daemonsy / hubot-heroku

A hubot library that exposes heroku commands, with focus of letting non privileged developers deploy but not run dangerous commands
26 stars 16 forks source link

Add Heroku Status command #26

Open jacobsmith opened 8 years ago

jacobsmith commented 8 years ago

There is currently a heroku-status hubot script at https://github.com/github/hubot-scripts/blob/master/src/scripts/heroku-status.coffee . However, if my understanding of how the hubot eco-system has changed is correct, additional pull requests into hubot-scripts is no longer the preferred method. I think pulling that same functionality into this script would make sense, especially for verifying if Heroku is functioning correctly. It would not need any of the API auth, as the status endpoint is public.

I would be more than willing to submit a PR for this, but I wanted to see if you felt this project could use that functionality before I forked and added the code!

daemonsy commented 8 years ago

I think it's a useful addition, I think we are both probably thinking about using the official API.

Happy to receive a PR for this! :)

jacobsmith commented 8 years ago

Awesome, thanks! I'm working on a PR for this and have a request out to Heroku for some more documentation on what failure response JSON looks like, just so the tests can be more accurate.