daeuniverse / dae

eBPF-based Linux high-performance transparent proxy solution.
GNU Affero General Public License v3.0
2.62k stars 165 forks source link

fix: Opt out TCP sockmap bypass by default #518

Closed jschwinger233 closed 1 month ago

jschwinger233 commented 1 month ago

Once the kernel issue1 is fixed and backported to TLS, I'll open another pull request as a follow-up to automatically enable this option if kernel has the patches.

Background

A kernel issue (confirmed by community) breaks TCP clients (e.g. glider) who use splice syscall when enabling bpf sockmap redirect. This PR opts out that performance optimization until kernel bug is fixed.

Checklist

Full Changelogs

Issue Reference

Closes #[issue number]

Test Result

sumire88 commented 1 month ago

Thanks for raising this. Is there any correlation between #505 and this PR?

jschwinger233 commented 1 month ago

Thanks for raising this. Is there any correlation between #505 and this PR?

Most likely not. This feature only affects local TCP, shouldn't have something to do with WAN UDP.