search

daevaorn / djapian

High level Xapian integration for Django
Other
6 stars 3 forks source link

Fix signal to Signals refactory made in Django #19

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The revision 8223 came with lots of changes in the signals system, and to
adapt to them we must declare a "**kwargs" argment to signal functions.

Original issue reported on code.google.com by mari...@gmail.com on 6 Aug 2008 at 5:36

GoogleCodeExporter commented 9 years ago 
Done

Original comment by mari...@gmail.com on 6 Aug 2008 at 5:37

Attachments:

GoogleCodeExporter commented 9 years ago 
As of Django changeset 8291, the formerly deprecated dispatcher.connect function
(/djapian/backend/base.py lines 171-172) is backwards incompatible and should be
replaced with the refactored Signals.

http://code.djangoproject.com/wiki/BackwardsIncompatibleChanges#Removedseveralmo
redeprecatedfeaturesfor1.0
http://code.djangoproject.com/wiki/BackwardsIncompatibleChanges#Signalrefactorin
g

Original comment by google%b...@gtempaccount.com on 12 Aug 2008 at 1:57

GoogleCodeExporter commented 9 years ago 
I believe changing line 171/172 of backend/base.py from the dispatcher.connect()
calls to:

        signals.post_save.connect(post_save, sender=self.model)
        signals.pre_delete.connect(pre_delete, sender=self.model)

Should make it compatible with 1.0-beta

Original comment by jbmendel...@gmail.com on 15 Aug 2008 at 7:37

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Comment 3 (jbmendelson) fix is working for me on r8391.

Original comment by google%b...@gtempaccount.com on 15 Aug 2008 at 8:38

GoogleCodeExporter commented 9 years ago 
Fixed to current trunk.

Original comment by daevaorn on 19 Aug 2008 at 9:16