search

daffidwilde / matching

A package for solving matching games
https://daffidwilde.github.io/matching/
MIT License
149 stars 42 forks source link

Move unmatching inside `second_phase` of SR #125

Closed daffidwilde closed 3 years ago

daffidwilde commented 3 years ago

This was causing simple examples to fail because the second phase of the algorithm never kicked in. By moving the unmatching, this is avoided, and is fine because of the corollaries in Irving's paper.

Thanks to @MartinMohlenkamp on #124 for raising this issue.

daffidwilde commented 3 years ago

I am expecting doctests to fail. #126 fixes that issue. Need to add the example tests for SR.