search

dafny-lang / dafny

Dafny is a verification-aware programming language
https://dafny.org
Other
2.94k stars 261 forks source link

Chore: Help message for when nightly tests fail #5869

Closed MikaelMayer closed 3 weeks ago

MikaelMayer commented 3 weeks ago

Description

Whenever nightly tests fails, some tests are failing but it's not obvious how to fix nightly tests. There is some documentation but I think it's nicer for developers to know

  1. If there is currently an action that is likely to resolve it soon.
  2. If not, what action they can take.

How has this been tested?

Investigating this during a nightly test failure. It gives the following helpful clickable message:

Error: Last run of nightly-build.yml did not succeed: https://github.com/dafny-lang/dafny/actions/runs/11562412876 A run of nightly-build.yml is currently in_progress: https://github.com/dafny-lang/dafny/actions/runs/11576162026, just re-run this test once it is finished.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

keyboardDrummer commented 3 weeks ago

I imagine you weren't able to test these changes, so if we merge them we risk breaking our builds (not the end of the world, we can revert). Is that right?

MikaelMayer commented 2 weeks ago

I imagine you weren't able to test these changes, so if we merge them we risk breaking our builds (not the end of the world, we can revert). Is that right?

The only execution path that wasn't tested during the development of this PR is the one starting with

\nAt the time of checking, no fix was underway.\n....

But since it's only text, urls that exist, I'm pretty confident that this error message won't break our builds. And if it did, as you say. it would be easy to spot and to fix on the go.