Open stefan-aws opened 1 year ago
1) Why do you propose separate files? In my review of the library, I'm considering proposing fewer files, so there need to be fewer includes.
2) Why are you proposing functions that simply replace constructors or discriminators?
3) I note that some of the new functions have type parameters that are not used. I'm not sure those will work.
I propose we remove https://github.com/dafny-lang/libraries/blob/master/src/Wrappers.dfy and create a separate file for each of the existing wrappers, and for any wrapper we add in the future. (Perhaps it would be good to group them in one folder.) In particular, I suggest that we extend the existing code for the result monad such that it contains at least the code below. Please ignore the include of Wrappers.dfy for now. I am particularly impressed that Dafny proves all monad laws by itself.