search

dafortune / hapi-qs

Bring back qs support for hapi 12
10 stars 7 forks source link

feat: parse payload on multipart/form-data request #8

Closed jo closed 8 years ago

jo commented 8 years ago

Closes #7

dafortune commented 8 years ago

Thanks so much! Great update! Could you add a quick test for this improvement? I have very little time this week. Otherwise I could probably do next week and merge

If you want, you can use https://github.com/daf-spr/hapi-qs/blob/master/tests/features/parse-payload.test.js as reference. Thanks!

jo commented 8 years ago

Hi @daf-spr,

I changed the test you mentioned to test against both form data types.

dafortune commented 8 years ago

Great! Thanks, just a minor detail (a couple of missing semicolons) and it is good to go.

jo commented 8 years ago

I added the two missing semicolons.

It would be great to include a linter which runs as part of the test. I recommend standard.

dafortune commented 8 years ago

Great! Thanks. Will create a separate issue to add a linter.