dafriedman97 / mlbook

Repository for the free online book Machine Learning from Scratch (link below!)
https://dafriedman97.github.io/mlbook/content/introduction.html
MIT License
1.1k stars 208 forks source link

3 changes #7

Closed dipranjan closed 4 years ago

dipranjan commented 4 years ago
  1. Loss function note added - ch7
  2. Chain rule example added - appendix math
  3. Sigmoid function image added - ch7

Might need to do a round of QC once, I am not extremely comfortable in Latex, still tried my best

dafriedman97 commented 4 years ago

For some reason these changes are looking a little funny on the "files changed" view (I can't see the side by side comparisons--seems to be showing that ~200 lines are being added). I might add these changes manually if that's all right?

dipranjan commented 4 years ago

Yeah actually the problem is that your gh-pages branch does not have any concept.md file. So since I wanted to make a change in that file I had to copy the file from the master branch and then add the change to it. Which is why it is showing 200 lines added as essentially the entire file is new to the gh-pages branch.

If you plan on merging the changes via gh-pages branch please ensure that master and gh-page branches are in sync. You can merge 200 lines it should not be a problem as it has the same content as the master branch.

dipranjan commented 4 years ago

You have already made the changes