Migrate to pyproject.toml

daft-dev / daft

Render probabilistic graphical models using matplotlib

https://docs.daft-pgm.org

MIT License

675 stars 120 forks source link

Migrate to pyproject.toml #163

Closed nstarman closed 12 months ago

nstarman commented 12 months ago

setup.py is deprecated for setuptools-scm
Also allows for dropping setuptools as a runtime requirement in favor of importlib.metadata.
ran pre-commit, which changed some commas.

nstarman commented 12 months ago

Any objections to migrating to a src layout?

dfm commented 12 months ago

Thanks! No concerns about switching to src!

nstarman commented 12 months ago

In this, or a followup PR?

dfm commented 12 months ago

I have no preference either way! Thanks again.

nstarman commented 12 months ago

Then I'll do it in 2 stages, with this PR for pyproject.toml and a followup for src-layout. What's the minimum python you want to support? I realized that I assumed importlib.metadata was available (py3.8+) importlib_metadata can be used for py3.7-.

dfm commented 12 months ago

Thanks! I'm happy to require >3.9.

nstarman commented 12 months ago

Done! I can squash, unless you use S&M commits.

dfm commented 12 months ago

Thanks!! 🎉