search

daft-engineers / vocoder

Open source vocoder designed for the Raspberry Pi.
https://daft-engineers.github.io/vocoder/
Mozilla Public License 2.0
11 stars 0 forks source link

break main.cc #52

Closed MHCooke closed 1 year ago

MHCooke commented 1 year ago

ensure merge is blocked when CI fails

MHCooke commented 1 year ago
image

oh dear, need to fix that

MHCooke commented 1 year ago

There we go, figured out how to mark them as required. I've chosen static analysis, formatting and unit tests (since unit tests passing requires build to pass too). Should I just turn them all on, or leave it as is?

bear-in-the-air commented 1 year ago

Those make sense to me, We just want all CI to pass before merge is allowed.

MHCooke commented 1 year ago

Have verified that bad code cannot be merged