search

daft-engineers / vocoder

Open source vocoder designed for the Raspberry Pi.
https://daft-engineers.github.io/vocoder/
Mozilla Public License 2.0
11 stars 0 forks source link

Added rms module #76

Closed Jambls closed 1 year ago

Jambls commented 1 year ago

Added RMS module, working with doubles.

MHCooke commented 1 year ago

I don't understand why my threaded stuff needed synchronisation to run the unit tests without hanging, but for some reason yours does not. I've run your code locally with a large number of loops and it seems stable, which is good enough for unit tests.

MarkAHarley commented 1 year ago

I think we should standardise on either defining classes in header files or just prototypes and implementing in a .cc file because atm it varies from file to file.

Jambls commented 1 year ago

I think we should standardise on either defining classes in header files or just prototypes and implementing in a .cc file because atm it varies from file to file.

This one and the mixer class use templates, which need to be in headers apparently.

MarkAHarley commented 1 year ago

I think we should standardise on either defining classes in header files or just prototypes and implementing in a .cc file because atm it varies from file to file.

This one and the mixer class use templates, which need to be in headers apparently.

Struggling to understand why that's the case, want to take a closer look tomorrow morning, but arguably this is outside of the scope of this pr so I'm happy enough to approve.