Fixes issue on lockout observation window detection

dafthack / DomainPasswordSpray

DomainPasswordSpray is a tool written in PowerShell to perform a password spray attack against users of a domain. By default it will automatically generate the userlist from the domain. BE VERY CAREFUL NOT TO LOCKOUT ACCOUNTS!

MIT License

1.78k stars 377 forks source link

Fixes issue on lockout observation window detection #24

Closed DialupDownload closed 3 months ago

DialupDownload commented 3 years ago

For an unknown reason, on Windows 10 Version 10.0.18363 with PowerShell 5.1, the current code fails to properly detect lockout Windows and reports errors about NullArray and ConvertLargeIntegerToInt64

This rewrites the Get-ObservationWindow function to work with above Window 10 / PowerShell version.

donovan-jasper commented 3 months ago

thanks for the pr! i pulled a different fix for this that didn't require the AD PS module as it may not always be available

your contribution is appreciated, thx for bringing attention to this. if you have anything else to add please open more pr's in the future!