search

dag / vim-fish

Vim support for editing fish scripts
MIT License
431 stars 59 forks source link

Fixed illegal character error, removed "j" formatoption #13

Closed ashwin closed 11 years ago

ashwin commented 11 years ago

There is no formatoption named "j" in Vim.

dag commented 11 years ago

Ah there is, but it's recent.

j   Where it makes sense, remove a comment leader when joining lines.  For
    example, joining:
        int i;   // the index
                 // in the list
    Becomes:
        int i;   // the index in the list

Perhaps it would be better to add this flag separately with :silent! setlocal?

ashwin commented 11 years ago

@dag I didn't realize there was a newer version of Vim. I'm using Vim 7.3 on Ubuntu 12.04 LTS.

Yes, it might be better to add this flag separately. I suspect that a large base of your addon users will still be on Vim 7.3 :)

Also, thanks for writing this addon :+1:

dag commented 11 years ago

7.3 is the latest major version but Vim has a weird versioning scheme where the version is the major version plus the individual numbered patches included. For me that is 1-415, 417-944. You probably have a build that lacks the particular patch number for the j flag.

ashwin commented 11 years ago

@dag I learn something new everyday. Thanks :)