search

dag / vim-fish

Vim support for editing fish scripts
MIT License
432 stars 59 forks source link

Update plugin to escape path to `bin/man.fish` #37

Closed jsatk closed 6 years ago

jsatk commented 7 years ago

Previously an error would throw if the path to /bin/man.fish involved spaces or other special characters. This commit escapes the string before having Vim parse it.

Resolves https://github.com/dag/vim-fish/issues/36#issuecomment-254576309

jsatk commented 7 years ago

This PR addresses the same issue as https://github.com/dag/vim-fish/pull/32 but in a slightly different way. Will let the maintainer decide which is the best solution and merge.

jsatk commented 7 years ago

@dag Can we get this merged? Thanks!

jsatk commented 7 years ago

It appears this is an abandoned repo.

dag commented 6 years ago

Oops. Yours is probably the better fix, but since you closed this I missed it and merged the other one. Maybe I'll fix it manually, but feel free to open a new PR because I might not get to it.

jsatk commented 6 years ago

Reopened @dag. Thanks! I appreciate this plugin. Thanks for looking at this.

Also, I fixed the conflicts via the Github UI. So the commit history here is kinda gross. I'd recommend squash merging.