search

dag81 / vesyncOpenhabPyPort

Port of Air Purifier support to openhab binding
3 stars 0 forks source link

LUH-A602S-WEU not supported #5

Closed morrisb74 closed 2 years ago

morrisb74 commented 2 years ago

Guessing that it is the same as LUH-A602S-WUS, but the european version :)

dag81 commented 2 years ago

HI @morrisb74, I'll try to take a look at the weekend as I need to spin back up the dev environment systems. Unfortunately work is hectic at the moment, along with other bits but I'll try to do a build by next Monday with that code in.

dag81 commented 2 years ago

@morrisb74 are you running 3.3? I was about to upload a build that should that ID for you - if you could validate please?

dag81 commented 2 years ago

@morrisb74 please confirm this build works as expected when you can. It's built against 3.3 let me know if you need a build against 3.2 instead please? Thanks in advance

morrisb74 commented 2 years ago

@morrisb74 please confirm this build works as expected when you can. It's built against 3.3 let me know if you need a build against 3.2 instead please? Thanks in advance

Your release works, I used the 3.3.0 Snapshot, But I'm guessing not everyone wants to "Bleeding Edge" software :-D It automagically found it after adding (and configuring) the bridge... But don't understand why you want to mask the username :-) ...

dag81 commented 2 years ago

@morrisb74 Many thanks I'll merge that to main then. The "Bleeding Edge" bit - that was built against the PR I have for trying to get it into the official repo - so confirmed and validated code. It's only snapshot as thats currently how I know to build it against the different revisions. I think the masking is there simply as it's PII if open on the screen (struggling to remember). User's can always unmask from memory if req. (Maybe they will request thats changed when they review the PR).

dag81 commented 2 years ago

@morrisb74 yeap they reacted to the password field for the username as well :) That context has been removed for the PR into the main repo. Thanks for testing - have a great weekend.