search

dagger / dagger-for-github

GitHub Action for Dagger
https://github.com/marketplace/actions/dagger-for-github
Apache License 2.0
120 stars 25 forks source link

feat: support latest as a version and use it as the default input #115

Closed purpleclay closed 2 months ago

purpleclay commented 2 months ago

closes #114

purpleclay commented 2 months ago

This change has the added benefit of not needing to keep this repository in sync with each dagger release.

jedevc commented 2 months ago

cc @gerhard

One thing I do like about the current setup is that if you pin this repo to a specific version/tag then it forces a specific dagger version - instead of needing to track multiple versions.

That said, I've seen latest as a pattern as well, specifically with the docker build actions - so maybe this is also viable.

gerhard commented 2 months ago

Thanks for contributing this @purpleclay!

The problem with defaulting to latest is that we could break pipelines out of the blue. 0.8.0 had several breaking changes, 0.9.0 had a few & both 0.10.0 & 0.11.0 changed fundamental aspects in how the CLI & the Engine work together.

I am all for adding latest as an explicit version value. Would that work @purpleclay?

purpleclay commented 2 months ago

Thanks for contributing this @purpleclay!

The problem with defaulting to latest is that we could break pipelines out of the blue. 0.8.0 had several breaking changes, 0.9.0 had a few & both 0.10.0 & 0.11.0 changed fundamental aspects in how the CLI & the Engine work together.

I am all for adding latest as an explicit version value. Would that work @purpleclay?

@gerhard happy to make that change 👍

purpleclay commented 2 months ago

@gerhard I have made those changes now

gerhard commented 2 months ago

Looking at this now.

gerhard commented 2 months ago

Thank you @purpleclay 💪

This change is now available in the updated v5 as well as the new v5.3.0