search

dagger / dagger-for-github

GitHub Action for Dagger
https://github.com/marketplace/actions/dagger-for-github
Apache License 2.0
120 stars 25 forks source link

Rename `dagger-action` to something less confusing #21

Closed shykes closed 2 years ago

shykes commented 2 years ago

Problem

From the point of view of a Github Actions user, "dagger-action" makes perfect sense. But from the point of view of the Dagger community, it is confusing: is it a product called "action" by Dagger? Is it a way to perform an action in Dagger? Is it a clone of Github Actions by Dagger?

Solution

After discussion: the most pragmatic solution seems to be renaming this repo to dagger-for-github.

Alternative options

The following options were discussed:

  1. Borrowing from Docker's edition model: dagger-for-github
  2. Another variation on the edition model: dagger-on-github
  3. Minimalist variatin: dagger-github
  4. Same idea but more specific: dagger-gha

My preference right now is option 1: dagger-for-github. Simply because the format of "Docker for Mac", "Github for Mac" (fun fact: this is the inspiration for D4M :) is familiar to many developers.

shykes commented 2 years ago

cc @grouville @crazy-max

crazy-max commented 2 years ago

dagger-ghaction?

grouville commented 2 years ago

WDYT?

You're totally right. This action provides a way to use dagger in combination with GitHub.

I like the edition model: simple, known and to-the-point. Even though I agree that it sounds a little bit longer than: Docker for Mac (4 syllabus), the benefits far outweigh this little inconvenience.

Dagger on Github is a little more accurate atm than Dagger for Github, as it literally brings Dagger on Github.

However, it's less familiar to developers and feels "more agnostic" in my opinion. We don't know the evolution that this action might take in the future, it may become a little more than just Dagger on Github: something more like the best Dagger experience of Dagger for Github.

My guess would be to follow your guts, and not reinvent the wheel.

I checked and Vercel follows the same model.

grouville commented 2 years ago

dagger-ghaction?

It totally fits for this use case, but I'm having a hard time seing how we would port this model with Gitlab and Bitbucket terminology?

shykes commented 2 years ago

Let's go with dagger-for-github. I updated the top comment. What work needs to be done besides renaming the github repo? @grouville can you track this and let me know when we are clear to rename?

cc @aluzzardi who owns project infra.