search

dagger / dagger-for-github

GitHub Action for Dagger
https://github.com/marketplace/actions/dagger-for-github
Apache License 2.0
120 stars 25 forks source link

rename repo to dagger-for-github #22

Closed crazy-max closed 2 years ago

crazy-max commented 2 years ago

fixes #21

@shykes @aluzzardi would temporary need admin rights to the repo to rename it when merged and also check everything is ok in the actions marketplace.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

aluzzardi commented 2 years ago

@shykes @aluzzardi would temporary need admin rights to the repo to rename it when merged and also check everything is ok in the actions marketplace.

Done!

Thank you!

crazy-max commented 2 years ago

@aluzzardi I merge this one and will debrief with @grouville about the process.

crazy-max commented 2 years ago

@grouville We might also change the action name:

https://github.com/dagger/dagger-for-github/blob/2e5f57a90b1fd846ab90c865cd143aef6452000a/action.yml#L1

to Dagger for GitHub so link in the marketplace would be https://github.com/marketplace/actions/dagger-for-github which would be more aligned with repo name.

Atm still https://github.com/marketplace/actions/dagger-action

shykes commented 2 years ago

In the context of Github marketplace, it kind of makes sense that it would be https://github.com/marketplace/actions/dagger seems more natural

Does that compatible with keeping the dagger-for-github name elsewhere, or will it confuse users?

On Feb 25, 2022, at 12:27, CrazyMax @.***> wrote:

 @grouville We might also change the action name:

https://github.com/dagger/dagger-for-github/blob/2e5f57a90b1fd846ab90c865cd143aef6452000a/action.yml#L1

to Dagger for GitHub so link in the marketplace would be https://github.com/marketplace/actions/dagger-for-github.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

crazy-max commented 2 years ago

In the context of Github marketplace, it kind of makes sense that it would be https://github.com/marketplace/actions/dagger seems more natural

We can't unfortunately. Name in marketplace is tied to username/orgname on GitHub so we can't pick /dagger as it's already used by dagger itself :sweat_smile:.

shykes commented 2 years ago

Makes sense. I think most people (me included) will copy-paste the workflow yaml anyway. Thanks!

grouville commented 2 years ago

le (me included) will copy-paste the workflow yaml anyway. Thanks!

do you prefer appearing as dagger-action in the marketplace (as it is now) ? or dagger-for-github ?

shykes commented 2 years ago

For consistency, I would prefer dagger-for-github. Less different words to remember :)