search

dagger / dagger-for-github

GitHub Action for Dagger
https://github.com/marketplace/actions/dagger-for-github
Apache License 2.0
120 stars 25 forks source link

chore(dev): getInputList helper func #46

Closed crazy-max closed 2 years ago

crazy-max commented 2 years ago

follow-up https://github.com/dagger/dagger-for-github/pull/44#discussion_r847800469

Adds getInputList func. I don't use the getMultilineInput from the core module because because it lacks some sanitizing logic and also doesn't handle comma delimiter that could be useful in the future.

Also adds asyncForEach so you could iterate over this list for the multi args feature we talked about.

cc @marcosnils @joaofnds

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

codecov-commenter commented 2 years ago

Codecov Report

Merging #46 (d0d5d21) into main (14118c6) will decrease coverage by 4.59%. The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   94.59%   90.00%   -4.60%     
==========================================
  Files           1        2       +1     
  Lines          37       50      +13     
  Branches        7        9       +2     
==========================================
+ Hits           35       45      +10     
- Misses          1        3       +2     
- Partials        1        2       +1
Impacted Files Coverage Δ
src/context.ts 76.92% <80.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14118c6...d0d5d21. Read the comment docs.