dagger / dagger-for-github

GitHub Action for Dagger
https://github.com/marketplace/actions/dagger-for-github
Apache License 2.0
120 stars 25 forks source link

fix: use native exec proc to avoid sanitization of the toolkit one #52

Closed crazy-max closed 7 months ago

crazy-max commented 2 years ago

just testing with child_process as the one from GitHub core toolkit sanitizes the command being passed which leads to issues like #40.

works fine: https://github.com/dagger/dagger-for-github/runs/6104146243?check_suite_focus=true#step:3:32

11:48PM INF actions.test._exec | computing
11:48PM INF actions.test._exec | completed    duration=100ms
11:48PM INF actions.test._exec | #5 0.076 hello GitHub Actions

but not quite happy about it as streamed output leaks in collapsible groups: https://github.com/dagger/dagger-for-github/runs/6104146243?check_suite_focus=true#step:3:18

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

jpadams commented 7 months ago

@crazy-max I'm going to close this Draft PR since we're moving from JS/TS to a simpler composite action using the new Dagger CLI v0.9.3+. Thanks again!