search

dagger / dagger-for-github

GitHub Action for Dagger
https://github.com/marketplace/actions/dagger-for-github
Apache License 2.0
124 stars 26 forks source link

Export GHA runtime env directly. #56

Closed sipsma closed 2 years ago

sipsma commented 2 years ago

This removes the need for all users to add the separate ghaction-github-runtime action before using Dagger in GHA.

Signed-off-by: Erik Sipsma erik@sipsma.dev

Marking as a draft so I can test it (CI won't run in my fork).

crazy-max commented 2 years ago

This is not necessary. GitHub runtime is always exposed in actions (uses:).

https://github.com/crazy-max/ghaction-github-runtime is only necessary for commands invoked in run: type steps in a workflow like https://github.com/dagger/dagger/blob/2c195bcac4e133e2ed7396b3b73a0003e6f51eb9/.github/workflows/dagger-ci.yml#L76-L77

sipsma commented 2 years ago

@crazy-max Thanks! That's a much better solution to this. Closing this PR.