search

dagger / dagger-for-github

GitHub Action for Dagger
https://github.com/marketplace/actions/dagger-for-github
Apache License 2.0
124 stars 26 forks source link

rename dagger to dagger-cue #79

Closed marcosnils closed 1 year ago

marcosnils commented 1 year ago

waiting on:

fixes #78

this will require releasing a new major version since it breaks backwards compat.

Signed-off-by: Marcos Lilljedahl marcosnils@gmail.com

gerhard commented 1 year ago

WDYT @marcosnils, should we close this in favour of https://github.com/dagger/dagger-for-github/issues/80? Until we have a dagger-cue v0.3 - specifically https://github.com/dagger/dagger/pull/3565 - I don't think that we should invest more time in the migration. How do you think about this @shykes? cc @jlongtine

jlongtine commented 1 year ago

@gerhard I agree.

marcosnils commented 1 year ago

Agree, I thought the cue-sdk branch had a way to build dagger-cue without all the new refactoring stuff in case we needed to ship a bugfix or something. If that's not the case, in this case this PR can be closed as IIUC, the current cue-sdk branch is not complete and is not intended to be used from source yet. Is that correct @jlongtine ?

jlongtine commented 1 year ago

Agree, I thought the cue-sdk branch had a way to build dagger-cue without all the new refactoring stuff in case we needed to ship a bugfix or something. If that's not the case, in this case this PR can be closed as IIUC, the current cue-sdk branch is not complete and is not intended to be used from source yet. Is that correct @jlongtine ?

The current cue-sdk branch contains the v0.2/Europa codebase. So, it is intended to be used in its current state.

I'm pretty sure the current build method is using go-releaser.

marcosnils commented 1 year ago

@jlongtine but I thought the cue-sdk branch also had all your in-progress work to migrate to cloak? Is that done already?

jlongtine commented 1 year ago

@jlongtine but I thought the cue-sdk branch also had all your in-progress work to migrate to cloak? Is that done already?

Only on my fork. Hasn't been merged. Not done. There are engine features that aren't finished yet that cause some issues for some Europa features.

marcosnils commented 1 year ago

Only on my fork. Hasn't been merged. Not done. There are engine features that aren't finished yet that cause some issues for some Europa features.

got it. In that case, leaving that Dockerifle there is useful in case we need to push a fix to Europa that someone might need in their CI which is using the dagger-for-github action. I think it's very unlikely to happen, but leaving the Dockerfile there doesn't hurt.